← Back to issue list

python plugin: use extracted pip

View original Github issue

Metadata

Project
snapcraft
Number
#1607
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1607 (commit 4adec3013) simplified the Python plugin and its tests by using the pip extracted into its own part from earlier commits, with no functional change.

Resolution: closed resolved

Reason: The PR was approved by two reviewers and merged into master as commit 4adec3013 ("python plugin: use extracted pip (#1607)"). Long-running integration test failures were traced by kyrofa to a stale test still using `packages` instead of the renamed `python-packages` key; after the fix the tests passed twice in a row and the PR landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Simplify the Python plugin and its tests by using the independently tested pip that was extracted in previous commits. All functionality should remain the same. Please help me test this PR thoroughly!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1607 (commit 4adec3013) simplified the Python plugin and its tests by using the pip extracted into its own part from earlier commits, with no functional change.
stealth/space-bunny-alpha — closed resolved Merged #1607 in commit 4adec3013, using the independently extracted pip to simplify the Python plugin and its tests without changing functionality.
qwen/qwen3.6-35b-a3b — — Merged after fixing integration test failures from an outdated variable. The change simplifies the Python plugin by using an independently tested, extracted pip, preserving functionality while reducing code complexity.
qwen3.6-35b-a3b-mtp-q6 — — Merged after fixing integration test failures caused by a packages to python-packages variable mismatch. The PR simplifies the Python plugin and tests by utilizing an independently extracted pip implementation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1625 (confidence 82%)

    PR that switched integration tests to the installed snapcraft snap; its landing caused the 'cannot open snaps-cache/snapcraft-pr1607.snap' errors that blocked this PR's test runs.

  • Blocked By: canonical/snapcraft#1625 (confidence 62%)

    kyrofa suspected #1625 caused the test failures; sergiusens confirmed it, requiring a follow-up branch before #1607 could be validated.

  • Related To: canonical/snapcraft#1719 (confidence 40%)

    Next python-plugin commit on the same file, shortly after 4adec3013, indicating no functional regression from the pip extraction.

Related issues

Issue Project State Summary Similarity
#1549 plugins: extract pip from python plugin snapcraft merged Merged #1549 in commit 871d4eee4, extracting the Python plugin's Pip wrapper into a reusable API with expanded tests; Python plugin behavior remained unchanged.
81%