plugins: extract pip from python plugin
Metadata
Current evaluation
Merged #1549 in commit 871d4eee4, extracting the Python plugin's Pip wrapper into a reusable API with expanded tests; Python plugin behavior remained unchanged.
Resolution: closed resolved
Reason: PR #1549 was merged as commit 871d4eee4, completing the Pip-wrapper extraction and making the component reusable by other plugins.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
At long last, making more progress on LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036) and #1444, here is the final bit of extraction necessary from the Python plugin: the Pip wrapper itself.
Note that unlike the other PRs, this is a bit of a refactor. The previous pip wrapper was a very private implementation detail of the Python plugin, and didn't need much of an API. This PR introduces a bit more of an API to it in the hopes of making it a little easier to use in other plugins. It also makes it easier to test.
This PR doesn't modify the Python plugin in any way just yet (that's the next PR).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1549 in commit 871d4eee4, extracting the Python plugin's Pip wrapper into a reusable API with expanded tests; Python plugin behavior remained unchanged. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 871d4eee4, extracting the Python plugin's Pip wrapper into a reusable API with improved testability; Python plugin behavior was unchanged. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor extracting the pip wrapper from the Python plugin. Introduces a public API to improve reusability and testability. Approved by two reviewers with passing CI checks, advancing a larger plugin extraction effort. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged extraction of the Pip wrapper from the Python plugin into a standalone component. This refactor introduces a public API to improve testability and enable reuse across other plugins, completing a multi-step refactoring effort. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1444
(confidence 95%)
The PR cited catkin pip support as broader groundwork motivating the extraction.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1607 python plugin: use extracted pip | snapcraft | merged | Merged PR #1607 (commit 4adec3013) simplified the Python plugin and its tests by using the pip extracted into its own part from earlier commits, with no functional change. | |
| #1540 plugins: extract python finder functions | snapcraft | merged | Merged as commit 822774f1f, extracting Python finder helpers into a shared module without changing plugin behavior and advancing the pip/catkin extraction effort. |