internal: don't reuse variable in OsRelease
Metadata
Current evaluation
Merged an internal cleanup that stops reusing a variable in OsRelease. Approved by two reviewers with passing CI checks. The change modifies a single file with two additions and two deletions.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Small follow-up after review.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged an internal cleanup that stops reusing a variable in OsRelease. Approved by two reviewers with passing CI checks. The change modifies a single file with two additions and two deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an internal code quality fix that prevents variable reuse in the OsRelease module. The change was applied as a minor follow-up to a previous review and successfully integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a code cleanup in the OsRelease module to prevent variable reuse. The change passed static and unit tests and was applied as a minor post-review follow-up. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #356 utils: remove Ubuntu-specific code from OsRelease | craft-parts | merged | Merged to remove Ubuntu-specific code from the OsRelease utility, resolving CRAFT-1584. Approved by reviewer, passed CI, and deleted 62 lines across two files after addressing linting rules in related PRs. | |
| #1981 tests: remove the internal os_release dependency | snapcraft | merged | Merged after approval. Removes the internal os_release dependency from tests, closing issue #1952. Two files changed with 52 additions and 10 deletions. |