cli: pass remote from container_config to clean method

Metadata

Project: snapcraft
Number: #1737
Type: pull request
State: merged
Author: kalikiana
Labels: —
Created: 2017-11-15 12:39 PM UTC
Updated: 2017-11-15 05:56 PM UTC
Closed: 2017-11-15 05:56 PM UTC

Current evaluation

Merged PR #1737 (commit f7bd699f8): `snapcraft clean` now passes the remote from container_config to the Cleanbuilder, so SNAPCRAFT_CONTAINER_BUILDS=<remote> deletes the container on that remote instead of a local one. Companion fix for refresh followed in #1739.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft master as commit f7bd699f8 ("cli: pass remote from container_config to clean method (#1737)"), after approval by @sergiusens and manual LXD testing by the author. The same remote-handling bug in `snapcraft refresh` was fixed by merged PR #1739 (commit 2f9265f23).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- With `SNAPCRAFT_CONTAINER_BUILDS=foo` running `snapcraft clean` will actually look for a local container, and clean that instead of the container on `foo` or do nothing.

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 05:39 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #1737 (commit f7bd699f8): `snapcraft clean` now passes the remote from container_config to the Cleanbuilder, so SNAPCRAFT_CONTAINER_BUILDS=<remote> deletes the container on that remote instead of a local one. Companion fix for refresh followed in #1739.
2026-10-03 05:39 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #1737 (commit f7bd699f8): `snapcraft clean` now passes the LXD remote from container_config so it deletes the remote container instead of a local one.
2026-09-25 03:10 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged #1737 (commit f7bd699f8), fixing snapcraft clean to use the configured LXD remote instead of targeting a local container.
2026-07-22 01:49 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Merged a fix ensuring snapcraft clean correctly targets remote containers when SNAPCRAFT_CONTAINER_BUILDS specifies a remote. The change passes the remote configuration to the clean method. Approved after testing and minor discussion on variable naming.
2026-07-19 11:47 PM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Merged a fix ensuring snapcraft clean targets the correct remote LXC container when SNAPCRAFT_CONTAINER_BUILDS is set. The change passes

Update history

No update history recorded yet.

Related work

Related To: canonical/snapcraft#1739 (confidence 90%)
Author noted refresh suffered the same bug (using a local container instead of the configured remote); fixed by merged PR #1739, commit 2f9265f23.
Likely Fixed By: canonical/snapcraft#1372 (confidence 40%)
Earlier merged PR that added containerbuild clean handling and unit tests for SNAPCRAFT_CONTAINER_BUILDS=1, the local-container behaviour this PR changed.

Related issues

Issue	Project	State	Summary	Similarity
#1739 lxd: refresh remote container	snapcraft	merged	Merged #1739 as 2f9265f23, fixing snapcraft refresh to honor the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.	75%
#1372 cli: Containerbuild clean	snapcraft	merged	Merged #1372, adding a unit test and fixing full clean behavior for SNAPCRAFT_CONTAINER_BUILDS=1.	73%