cli: pass remote from container_config to clean method
Metadata
Current evaluation
Merged a fix ensuring snapcraft clean correctly targets remote containers when SNAPCRAFT_CONTAINER_BUILDS specifies a remote. The change passes the remote configuration to the clean method. Approved after testing and minor discussion on variable naming.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
With `SNAPCRAFT_CONTAINER_BUILDS=foo` running `snapcraft clean` will actually look for a local container, and clean that instead of the container on `foo` or do nothing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix ensuring snapcraft clean correctly targets remote containers when SNAPCRAFT_CONTAINER_BUILDS specifies a remote. The change passes the remote configuration to the clean method. Approved after testing and minor discussion on variable naming. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix ensuring snapcraft clean targets the correct remote LXC container when SNAPCRAFT_CONTAINER_BUILDS is set. The change passes | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes snapcraft clean ignoring the remote in SNAPCRAFT_CONTAINER_BUILDS. Passes the remote config to the clean method, ensuring remote containers are deleted without affecting local ones. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1372 cli: Containerbuild clean | snapcraft | merged | Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked. | |
| #1739 lxd: refresh remote container | snapcraft | merged | Fixes snapcraft refresh to correctly target the remote LXD container specified in SNAPCRAFT_CONTAINER_BUILDS instead of defaulting to local. Merged after approval and successful testing. | |
| #1596114 adt, cannot snapcraft clean without remote parts when in use | snapcraft (launchpad) | closed | Fixed test failures where snapcraft clean failed due to missing remote parts cache. Updated the test suite to run snapcraft update before cleaning. Verified and closed. |