← Back to issue list

lxd: refresh remote container

View original Github issue

Metadata

Project
snapcraft
Number
#1739
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1739 as 2f9265f23, fixing snapcraft refresh to honor the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.

Resolution: closed resolved

Reason: PR #1739 was merged as commit 2f9265f23. The author demonstrated refresh using the configured remote, and a maintainer confirmed the change fixed the bug.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- With SNAPCRAFT_CONTAINER_BUILDS=foo running snapcraft refresh will actually look for a local container, and refresh that instead of the container on foo.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1739 as 2f9265f23, fixing snapcraft refresh to honor the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.
stealth/space-bunny-alpha — closed resolved Merged PR #1739 as commit 2f9265f23, making snapcraft refresh target the LXD remote from SNAPCRAFT_CONTAINER_BUILDS instead of a local container.
stealth/space-bunny-alpha — closed resolved Merged into main as commit 2f9265f23, fixing snapcraft refresh to target the LXD remote specified by SNAPCRAFT_CONTAINER_BUILDS instead of a local container.
stealth/space-bunny-alpha — closed resolved Merged PR #1739 as commit 2f9265f23, fixing snapcraft refresh to target the configured LXD remote instead of using a local container.
stealth/space-bunny-alpha — closed resolved Merged PR #1739 as commit 2f9265f23, making snapcraft refresh use the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of a local container.
stealth/space-bunny-alpha — closed resolved Merged PR #1739 as 2f9265f23, fixing snapcraft refresh to use the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of a local container.
stealth/space-bunny-alpha — closed resolved Merged PR #1739 as commit 2f9265f23, fixing snapcraft refresh to target the LXD remote specified by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.
qwen/qwen3.6-35b-a3b — — Fixes snapcraft refresh to correctly target the remote LXD container specified in SNAPCRAFT_CONTAINER_BUILDS instead of defaulting to local. Merged after approval and successful testing.
qwen3.6-35b-a3b-mtp-q6 — — Fixes snapcraft refresh ignoring the SNAPCRAFT_CONTAINER_BUILDS remote setting and incorrectly targeting a local LXD container. The change was merged after reviewer validation, with minor console output adjustments deferred for future iteration.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1737 (confidence 90%)

    Related fix that passed the configured LXD remote through the clean command.

  • Related To: snapcraft#1412 (confidence 85%)

    Earlier merged PR that introduced snapcraft refresh support for LXD containers.

Related issues

Issue Project State Summary Similarity
#1412 lxd: snapcraft refresh in containers snapcraft merged Merged PR #1412 as 3d511c5eb, making LXD container refresh install Snapcraft once while allowing packages and snaps to be updated in reusable containers.
86%
#1722049 core refresh in container build breaks build snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#2098 (commit 7666a74a7), which waits for active snap refreshes before injecting build snaps into reusable LXD containers.
78%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged PR #1364 as 99f5598ac, injecting the host's Snapcraft and core snaps into LXD containers so builds no longer use a mismatched Xenial archive version.
77%
#1585 lxd: pass SNAPCRAFT_PARTS_URI through into container snapcraft merged Merged in canonical/snapcraft#1585 (13ea598d5), forwarding SNAPCRAFT_PARTS_URI into LXD containers so cleanbuild can resolve remote parts; fixes Launchpad #1719951.
77%
#1737 cli: pass remote from container_config to clean method snapcraft merged Merged PR #1737 (commit f7bd699f8): `snapcraft clean` now passes the remote from container_config to the Cleanbuilder, so SNAPCRAFT_CONTAINER_BUILDS=<remote> deletes the container on that remote instead of a local one. Companion fix for refresh followed in #1739.
75%
#1546 cli: update parts cache in the container snapcraft merged Merged as 0dde02398: snapcraft update now refreshes the parts cache in the LXD container as well as the host. Complementary container refresh work landed in #1412.
74%
#2098 lxd: wait for on-going refreshes to finish snapcraft merged PR #2098 by kalikiana merged (commit 7666a74a7), adding a `snap watch` call before injecting core/snapcraft snaps into LXD containers so in-progress refreshes finish. Fixes #2037 and LP bug #1722049.
74%
#1746009 clean is checking lxd remote snapcraft (launchpad) closed Snapcraft now initializes the LXD remote lazily, so clean no longer starts a container unnecessarily; fixed by snapcore/snapcraft#1916 (dd4404843).
73%
#1655 lxd: distinguish argless clean from clean -s pull snapcraft merged Merged in snapcraft#1655 (ed32603c7), fixing LXD cleanup so bare clean removes build containers while clean -s pull preserves or recreates them.
72%
#1644 lxd: fix the push in container builds snapcraft merged Merged PR #1644 fixed LXD container-build artifact pushes; the change landed as commit d4a34e07d.
72%