← Back to issue list

lxd: fix the push in container builds

View original Github issue

Metadata

Project
snapcraft
Number
#1644
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1644 fixed LXD container-build artifact pushes; the change landed as commit d4a34e07d.

Resolution: closed resolved

Reason: PR #1644 was merged, with repository history identifying commit d4a34e07d as the resolution. The change corrected how LXD container builds push built artifacts.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1644 fixed LXD container-build artifact pushes; the change landed as commit d4a34e07d.
stealth/space-bunny-alpha — closed resolved Merged in PR #1644 as commit d4a34e07d, fixing how LXD container builds push built artifacts.
qwen/qwen3.6-35b-a3b — — Merged pull request fixing LXD container push builds. Approved by one reviewer, the change refactored test cases for better coverage and updated build logic. Review comments highlighted the need for Travis integration and broader testing beyond unit tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for LXD push failures during container builds. The update refactored unit tests to properly cover Cleanbuilder and Project code paths by separating test classes and renaming helper methods, ensuring adequate coverage before merge.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1625 (confidence 90%)

    A maintainer noted that PR #1625 was needed to test the change in Travis; it provided the integration-test setup rather than the fix.

Related issues

Issue Project State Summary Similarity
#1230 lxd: refactor Cleanbuilder into Containerbuild and add Project. snapcraft merged Merged PR #1230 (ce66ca561) replaced Cleanbuilder with a Containerbuild base class and added Project to create and reuse project-named LXD containers.
73%
#1263 lxd: pass through commands into the container snapcraft merged Merged #1263 as commit e0f28bd5c, routing snap-building and parts commands through LXD containers so remote/cleanbuild commands run inside the container environment.
72%
#1739 lxd: refresh remote container snapcraft merged Merged #1739 as 2f9265f23, fixing snapcraft refresh to honor the LXD remote named by SNAPCRAFT_CONTAINER_BUILDS instead of using a local container.
72%
#1762 lxd: delete container only if parts is empty snapcraft merged Merged PR #1762 (dbce9a058), changing LXD cleanup to delete a build container only after all parts are removed, preserving it for targeted cleans and making repeated cleans safe.
72%
#275 lxd: make push_file_io work on newer Ubuntu versions craft-providers merged Merged in PR #275 via commit c585931, updating LXD push_file_io for newer Ubuntu images without an ubuntu user and resolving #270.
71%
#1978 ci: switch to stable lxd and unconfined containers snapcraft merged Merged PR #1978 as commit c2d5a4f68, switching CI to stable LXD and using unconfined containers.
71%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged PR #1364 as 99f5598ac, injecting the host's Snapcraft and core snaps into LXD containers so builds no longer use a mismatched Xenial archive version.
71%
#1655 lxd: distinguish argless clean from clean -s pull snapcraft merged Merged in snapcraft#1655 (ed32603c7), fixing LXD cleanup so bare clean removes build containers while clean -s pull preserves or recreates them.
70%
#2529 build providers: idempotent destroy for LXD snapcraft merged Merged PR #2529 made LXD cleanup idempotent, preventing missing-container errors from masking launch failures; landed as commit 1b2905885.
70%