← Back to issue list

Add codespell support

View original Github issue

Metadata

Project
snapcraft
Number
#1770
Type
pull request
State
merged
Author
daniellimws
Labels
—
Created
Updated
Closed

Current evaluation

GCI contribution merged as commit 795628227: fixed repo-wide spelling errors and added codespell, first run standalone in Travis via tools/travis/run_codespell.sh with -q 4 and debian/changelog excluded.

Resolution: closed resolved

Reason: PR #1770 was approved and merged into snapcraft as commit 795628227 ('spelling: fixed spelling and added codespell support (#1770)'), changing 22 files (+33/-27). At maintainer sergiusens' request, the Travis install stanza was moved into a new executable script tools/travis/run_codespell.sh, and a follow-up PR #1783 (commit 2d2646ee6) wired codespell into the static test stage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If applied, this commit will fix all spelling errors in the current state of the repository. Furthermore, add a test in .travis.yaml to do so on pull requests. Based on Google Code-in task https://codein.withgoogle.com/dashboard/task-instances/5347598271512576/

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved GCI contribution merged as commit 795628227: fixed repo-wide spelling errors and added codespell, first run standalone in Travis via tools/travis/run_codespell.sh with -q 4 and debian/changelog excluded.
stealth/space-bunny-alpha — closed resolved GCI contribution merged as commit 795628227: fixed repo spelling errors and added codespell config/wrapper (tools/travis/run_codespell.sh); CI wiring followed in #1783.
stealth/space-bunny-alpha — closed resolved PR #1770 merged in commit 795628227, fixing repository spelling and adding codespell support; #1783 later added the check to static tests.
qwen/qwen3.6-35b-a3b — — Merged codespell integration to automatically detect and fix repository spelling errors. Reviewer feedback refined the Travis CI configuration into a dedicated shell script and adjusted typo exclusions. Approved and merged after addressing all comments.
qwen3.6-35b-a3b-mtp-q6 — — Merged codespell integration to automatically detect and fix spelling errors. Travis CI was refactored to use a dedicated shell script for checks, excluding specific files and patterns. Commit messages were adjusted per maintainer feedback.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1783 (confidence 90%)

    Follow-up PR that ran codespell as part of the static tests (commit 2d2646ee6), completing the CI wiring suggested in this PR's review

  • Superseded By: snapcraft#1783 (confidence 45%)

    The standalone Travis codespell job was later folded into the static test stage

Related issues

Issue Project State Summary Similarity
#1296 ci: enable codespell charmcraft merged Merged PR #1296, fixing spelling errors in 3f10087f and enabling codespell in CI in 1d39e13d.
77%
#616 codespell charmcraft merged Merged PR #616 (commit c5e26d50), correcting codespell-reported typos across 16 files (+37/-37 lines).
73%
#167 lint:fix codespell typos craft-providers merged Merged PR #167 (commit ab325f2) fixing codespell-reported typos in 2 files (+2/-2), approved by a maintainer reviewer.
72%
#389 build(deps): update codespell craft-application merged Codespell dependency update merged in #389, changing two files; resolving commit: 70018156.
72%
#2162 tests: new codespell, narrowed checks and better execution order snapcraft merged PR #2162 merged into master (44ae843f) by sergiusens: bumped codespell to 0.12.0, ran mypy before spell checking, narrowed checked directories, and fixed newly found spelling errors in runtests.sh/static checks.
71%