tests: new codespell, narrowed checks and better execution order
Metadata
Current evaluation
Updated codespell to 0.12.0, fixed spelling errors, narrowed search directories, and adjusted test execution order. Merged after approval and passing CI checks.
Suggested action: —
No scores available.
Issue body
- Run mypy first and only then do spell checking.
- Update codespell to 0.12.0 which has better detection.
- Fix spelling issues discovered by codespell.
- Narrow down the list of directories searched for (no need to look in
e.g.; parts).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Updated codespell to 0.12.0, fixed spelling errors, narrowed search directories, and adjusted test execution order. Merged after approval and passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated codespell to 0.12.0, corrected discovered spelling errors, narrowed search directories, and reordered checks to run mypy before spell checking. Coverage impact was negligible. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates codespell to 0.12.0, fixes spelling errors, narrows search directories, and reorders checks to run mypy before spell checking. Merged with negligible coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1783 tests: run codespell as part of static tests | snapcraft | merged | Merged following approval and passing CI. Integrates codespell into the static test suite to enforce spelling checks across five modified files. | |
| #389 style: change spelling for updated codespell | rockcraft | merged | Merged a one-line spelling correction to comply with updated codespell rules, resolving issue #388. Approved by three reviewers and passed CI checks. | |
| #1296 ci: enable codespell | charmcraft | merged | Merged following approval by two reviewers. Enables the codespell CI check across 14 files. The change fixes existing spelling errors and updates configuration in two separate commits. | |
| #616 codespell | charmcraft | merged | Merged after single reviewer approval. Applied codespell suggestions across 16 files, correcting 37 lines of spelling errors. No unresolved comments or CI issues. | |
| #389 build(deps): update codespell | craft-application | merged | Merged after approval by two reviewers and passing CI checks. Updates the codespell dependency across two files with minor line adjustments. | |
| #1770 Add codespell support | snapcraft | merged | Merged codespell integration to automatically detect and fix repository spelling errors. Reviewer feedback refined the Travis CI configuration into a dedicated shell script and adjusted typo exclusions. Approved and merged after addressing all comments. | |
| #35 lint: skip more commonly ignored files and directories with codespell | starbase | merged | Merged an update to the codespell configuration that skips additional commonly ignored files and directories. Approved by a reviewer, passed CI checks, and applied with a minimal one-file change. | |
| #4059 lint: update and freeze codespell | snapcraft | merged | Merged pull request updating and freezing the codespell linting tool. Approved by one reviewer and passing CI, the change modified four files (+4/-4 lines) and was successfully integrated into the main branch. | |
| #372 build(deps): update dependency codespell to v2.4.1 | craft-cli | merged | Merged automated dependency update upgrading codespell from v2.3.0 to v2.4.1. Generated by Renovate bot, the change touched two files, passed all CI checks, and received approval from two reviewers. | |
| #3028 static: add codespell excludes for .direnv | snapcraft | merged | Merged a single-line update to exclude the .direnv directory from codespell checks. Approved by one reviewer and passed CI. |