tests: new codespell, narrowed checks and better execution order
Metadata
Current evaluation
PR #2162 merged into master (44ae843f) by sergiusens: bumped codespell to 0.12.0, ran mypy before spell checking, narrowed checked directories, and fixed newly found spelling errors in runtests.sh/static checks.
Resolution: closed resolved
Reason: The pull request was approved and merged into master as commit 44ae843f393014e365c6c4369d1523a481d54cfd, appearing in the runtests.sh history as "tests: update codespell, the scope of checks and ordering of static tests (#2162)" (d16e21b21), updating codespell to 0.12.0 and reordering static checks so mypy runs before codespell.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Run mypy first and only then do spell checking.
- Update codespell to 0.12.0 which has better detection.
- Fix spelling issues discovered by codespell.
- Narrow down the list of directories searched for (no need to look in
e.g.; parts).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2162 merged into master (44ae843f) by sergiusens: bumped codespell to 0.12.0, ran mypy before spell checking, narrowed checked directories, and fixed newly found spelling errors in runtests.sh/static checks. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2162 as 44ae843f393014e365c6c4369d1523a481d54cfd, updating codespell to 0.12.0, running mypy first, narrowing searched directories, and fixing spelling errors. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated codespell to 0.12.0, fixed spelling errors, narrowed search directories, and adjusted test execution order. Merged after approval and passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated codespell to 0.12.0, corrected discovered spelling errors, narrowed search directories, and reordered checks to run mypy before spell checking. Coverage impact was negligible. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1783
(confidence 88%)
Earlier PR (commit 2d2646ee6) that first wired codespell into the static test suite, which #2162 refines.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1783 tests: run codespell as part of static tests | snapcraft | merged | Merged as commit 2d2646ee6: runtests.sh static now invokes codespell, wiring the spelling checker (config added in #1770) into the static test suite; it later moved to tox/Makefile targets. | |
| #616 codespell | charmcraft | merged | Merged PR #616 (commit c5e26d50), correcting codespell-reported typos across 16 files (+37/-37 lines). | |
| #167 lint:fix codespell typos | craft-providers | merged | Merged PR #167 (commit ab325f2) fixing codespell-reported typos in 2 files (+2/-2), approved by a maintainer reviewer. | |
| #728 build(deps): update dependency codespell to v2.4.1 (main) | craft-application | merged | Renovate PR merged, bumping codespell 2.3.0 -> 2.4.1 via commit 4aa9d0f2 (2 files, +955/-955); all CI checks passed. Later superseded by #1141 (codespell 2.4.3). | |
| #1296 ci: enable codespell | charmcraft | merged | Merged PR #1296, fixing spelling errors in 3f10087f and enabling codespell in CI in 1d39e13d. | |
| #1770 Add codespell support | snapcraft | merged | GCI contribution merged as commit 795628227: fixed repo-wide spelling errors and added codespell, first run standalone in Travis via tools/travis/run_codespell.sh with -q 4 and debian/changelog excluded. | |
| #4059 lint: update and freeze codespell | snapcraft | merged | PR #4059 (maintainer lengau) updated and pinned/froze the codespell lint version to fix CI spelling-check failures; merged into main as commit 423d008 (255255f7b) and backported to hotfix/7.3 by #4063 (1914eb975). |