← Back to issue list

tests: run codespell as part of static tests

View original Github issue

Metadata

Project
snapcraft
Number
#1783
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 2d2646ee6: runtests.sh static now invokes codespell, wiring the spelling checker (config added in #1770) into the static test suite; it later moved to tox/Makefile targets.

Resolution: closed resolved

Reason: The PR was merged by maintainer kyrofa as commit 2d2646ee6 ("tests: run codespell as part of static tests (#1783)"), adding a codespell step to the static test runner. Follow-up work continued in #2162 and the later tox/Makefile migration, confirming the change landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 2d2646ee6: runtests.sh static now invokes codespell, wiring the spelling checker (config added in #1770) into the static test suite; it later moved to tox/Makefile targets.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1783 (commit 2d2646ee6), integrating codespell into the static test suite to enforce spelling checks.
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Integrates codespell into the static test suite to enforce spelling checks across five modified files.
qwen3.6-35b-a3b-mtp-q6 — — Integrated codespell into the static test suite to enforce automated spelling checks during CI. Successfully merged without discussion.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1770 (confidence 90%)

    Earlier PR (commit 795628227) fixed repo spelling and added codespell support/config that this PR hooked into the static tests.

  • Related To: canonical/snapcraft#2162 (confidence 55%)

    Follow-up PR (commit d16e21b21) later updated codespell, its check scope, and static test ordering.

Related issues

Issue Project State Summary Similarity
#2162 tests: new codespell, narrowed checks and better execution order snapcraft merged PR #2162 merged into master (44ae843f) by sergiusens: bumped codespell to 0.12.0, ran mypy before spell checking, narrowed checked directories, and fixed newly found spelling errors in runtests.sh/static checks.
76%