Add typings to some modules
Metadata
Current evaluation
Merged changes adding type hints to several modules. Approved by one reviewer, passed CI checks, and modified three files.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Added type hints to some modules.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding type hints to several modules. Approved by one reviewer, passed CI checks, and modified three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged addition of type hints to multiple modules. The external contributor passed static and unit tests, and the changes were integrated into the codebase without further discussion or modifications. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an external contribution adding type hints to several modules. The changes passed static analysis and unit tests, and were accepted without further discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #433 fix(tests): better typing for tests | starbase | merged | Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file. | |
| #1906 build(deps): update typing linters | charmcraft | merged | Merged after approval by two reviewers. Maintainer lengau committed the update to typing linters, modifying one file with two additions and two deletions. | |
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. |