fix(tests): better typing for tests
Metadata
Current evaluation
Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file.
Suggested action: —
No scores available.
Issue body
This change makes ty happy
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to test type annotations, resolving ty linter warnings. Changes were integrated directly without additional comments or revisions. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. | |
| #1716 test: fix ty 0.0.79 issues | craft-parts | merged | Merged after two approvals. Fixed unit test failures related to ty 0.0.79 across five files. CI checks passed. | |
| #278 tests: additional tests to improve coverage | fetch-service | merged | Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines. | |
| #3653 tests: pass proper type to run for version | snapcraft | merged | Merged a single-file change to pass the correct type to the run command for version testing. Approved by one reviewer with passing CI checks. | |
| #1812 Add typings to some modules | snapcraft | merged | Merged changes adding type hints to several modules. Approved by one reviewer, passed CI checks, and modified three files. | |
| #461 test: improve test coverage | fetch-service | merged | Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing. | |
| #458 test: improve test coverage | fetch-service | merged | Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage. | |
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #117 a couple of fixes for tests | charmcraft | merged | Merged to resolve issue #105. Approved by two reviewers, the pull request implements minor test corrections across two files with a +10/-1 line change. | |
| #415 tests: cast type expectation for organize assertions | craft-parts | merged | Merged a test update casting type expectations for organize assertions. Approved by one reviewer, modifying one file with two additions and one deletion. |