style(types): enable type checking with ty
Metadata
Current evaluation
Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes enabling type checking with the ty tool. The pull request passed lint and test validations, successfully integrating static type analysis into the project's style and build pipeline. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated. | |
| #472 style: enable ty by default | starbase | merged | Merged to enable the ty type checker by default. Approved by two reviewers with all CI checks passing. The minimal configuration change lays groundwork for eventually replacing mypy and pyright once ty reaches stable release. | |
| #6247 style: go all-in on ty | snapcraft | merged | Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139. | |
| #433 fix(tests): better typing for tests | starbase | merged | Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file. | |
| #6015 style: fix additional ty warnings | snapcraft | merged | Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970. | |
| #1126 style: fix ty errors | craft-application | merged | Merged a style update to replace pydantic with ty for type checking, leveraging ty's new Pydantic support. Approved by reviewers, passed CI checks, and integrated into the codebase. | |
| #2370 ci: add experimental workflow using ty for type checking | charmcraft | merged | Merged an experimental CI workflow adding ty type checking. All checks passed despite bot notifications of type errors, which were marked as informational. Approved by two reviewers and integrated into the repository. | |
| #223 style: switch from mypy+pyright to ty | craft-platforms | merged | Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines. | |
| #27 ci: type check with ty | craft-artifacts | merged | Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes. |