style(types): enable type checking with ty
Metadata
Current evaluation
Merged as d38e0f4: enabled Astral ty type checking, added it to the lint workflow, and included it in lint build dependencies.
Resolution: closed resolved
Reason: PR #407 was merged into main as commit d38e0f4. The commit adds ty to the lint target and install-lint-build-deps target; all reported CI checks passed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as d38e0f4: enabled Astral ty type checking, added it to the lint workflow, and included it in lint build dependencies. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #201, enabling ty for type checking with all CI checks passing. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#479
(confidence 90%)
Later commit 0e49c01 removed mypy and pyright and refined the type-checking setup.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #139 style(type): fix typing issues found by ty | craft-platforms | merged | Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553. | |
| #472 style: enable ty by default | starbase | merged | Merged PR #472 as commit 7982765, making Astral ty a default type-checking option while retaining existing checkers. | |
| #201 style: enable ty as stable type checker | craft-platforms | merged | Merged in craft-platforms#201 (commit 5407de0), enabling ty as the stable type checker in regular checks while retaining pyright and mypy for now. | |
| #885 style: enable type checking with ty | craft-providers | merged | Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files. | |
| #1207 style: replace mypy and pyright with ty | rockcraft | merged | Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files. |