snaps: do not validate snaps before install/refresh (Fixes LP#1901733)
Metadata
Current evaluation
Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation because store API branch checks already cover it; fixes LP#1901733.
Resolution: closed resolved
Reason: PR #3502 was merged as commit 7ab76e084. It removes pre-install/refresh validation and relies on the store API's existing branch validation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Branches are not advertised in store channels, the only way to check is to
to check with the store API, which `install` and `refresh` do already.
Fixes https://bugs.launchpad.net/snapcraft/+bug/1901733
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation because store API branch checks already cover it; fixes LP#1901733. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation; the store API validates branches, fixing LP#1901733. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3502 as 7ab76e084, removing store validation before snap install/refresh; follow-up #3505 (7fa96fb0d) completed pre-download validation removal. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3502, removing redundant pre-install/refresh snap validation because the store API already checks branches, fixing LP#1901733 (commit 7ab76e084). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Removes redundant snap validation before install and refresh, as the store API already handles branch checks. Approved by two reviewers, passed CI, and resolves Launchpad bug #1901733. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Removes redundant snap validation before install and refresh, as the store API already verifies branches. Fixes Launchpad bug #1901733. Achieved 100% diff coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3505
(confidence 95%)
Complementary merged PR removing pre-download validation for the same LP#1901733 branch-handling fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3505 snaps: don't validate snaps before `SnapPackage.download()` | snapcraft | merged | Merged PR #3505 as commit 7fa96fb0d, removing pre-download snap validation so Launchpad branches could be staged (LP#1901733). | |
| #129 Error when installing snaps | fetch-service | closed | Snap installation rejection was fixed by merged PR #145, correcting validation of successful Snap Store refresh responses. | |
| #2729 snaps: if snap is installed, don't check is_valid() | snapcraft | merged | Merged PR #2729 via commit 604b525be, skipping Snap Store validation for installed dependency snaps to reduce network traffic and support limited offline development. | |
| #3617 snap: do not refresh already installed snaps | snapcraft | merged | Merged PR #3617 via commit 22040ffc5, stopping Snapcraft from refreshing already installed snaps; implementation commit 9d4129398. | |
| #1815 repo: handle invalid snaps | snapcraft | merged | Merged PR #1815 in commit 89ce40718: invalid build-snaps now emit clear errors, and snap information fetches retry after network failures. |