snaps: do not validate snaps before install/refresh (Fixes LP#1901733)
Metadata
Current evaluation
Merged into master. Removes redundant snap validation before install and refresh, as the store API already handles branch checks. Approved by two reviewers, passed CI, and resolves Launchpad bug #1901733.
Suggested action: —
No scores available.
Issue body
Branches are not advertised in store channels, the only way to check is to
to check with the store API, which `install` and `refresh` do already.
Fixes https://bugs.launchpad.net/snapcraft/+bug/1901733
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Removes redundant snap validation before install and refresh, as the store API already handles branch checks. Approved by two reviewers, passed CI, and resolves Launchpad bug #1901733. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Removes redundant snap validation before install and refresh, as the store API already verifies branches. Fixes Launchpad bug #1901733. Achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Removes unnecessary pre-install and refresh snap validation, as the store API already performs these checks. Resolves Launchpad bug #1901733 with 100% test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3505 snaps: don't validate snaps before `SnapPackage.download()` | snapcraft | merged | Merged a fix that skips snap validation before SnapPackage.download(), resolving branch staging issues (LP#1901733). Approved by two reviewers, passed CI, and changed three files (+16/-11 lines). | |
| #2729 snaps: if snap is installed, don't check is_valid() | snapcraft | merged | Merged to skip store validation for installed snaps, reducing network traffic and enabling offline development. Approved by reviewer, passed CI, and applied with a single-line change. | |
| #3617 snap: do not refresh already installed snaps | snapcraft | merged | Merged changes to prevent refreshing already installed snaps by removing two lines of code. Approved by one reviewer and integrated into the main branch. | |
| #1692 fix: refresh build snaps if already installed | craft-parts | open | Refreshes build snaps when already installed to reflect channel changes, fixing #496. Has 2 approvals, 1 unresolved review comment, and mostly passing CI. | |
| #3618 snap: do not refresh already installed snaps | snapcraft | merged | Merged to prevent refreshing already installed snaps. Ported from #3617 to snapcraft_legacy, the approved change removes two lines of code. | |
| #161 snap: do not refresh already installed snaps | craft-parts | merged | Merged a port of snapcraft#3617 to craft-parts. The change prevents refreshing already installed snaps by removing two lines of code. Approved by one reviewer and passed CI checks. | |
| #5689 fix: remove unnecessary snapd_snap flag (#5316) | snapcraft | merged | PR #5316 merged, removing the unnecessary snapd_snap flag across two files and deleting 14 lines. The change received three approvals, passed all CI checks, and was successfully integrated. | |
| #1815 repo: handle invalid snaps | snapcraft | merged | Merged changes handling invalid snaps in build-snaps with a clear error message. Adds retries to information fetching for improved network failure debugging. Approved after resolving a minor CI typo. |