← Back to issue list

parts: support for grammar parsing

View original Github issue

Metadata

Project
snapcraft
Number
#3652
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3652 via commit cfbe60ac4 (merge 7708b7261), adding Craft Grammar parsing for part source, package, environment, and snap fields.

Resolution: closed resolved

Reason: The approved implementation was merged into snapcraft/7.0 through merge commit 7708b7261. Commit cfbe60ac4 adds grammar processing for supported part definition fields.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- CRAFT-820

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3652 via commit cfbe60ac4 (merge 7708b7261), adding Craft Grammar parsing for part source, package, environment, and snap fields.
stealth/space-bunny-alpha — closed resolved Merged #3652 into snapcraft/7.0, adding grammar parsing support for parts via commit cfbe60ac4 (merge 7708b7261).
qwen/qwen3.6-35b-a3b — — Added grammar parsing support for parts. The change was approved, passed CI, and merged into the snapcraft/7.0 branch. It modifies three files, adds 248 lines, and increases test coverage by 0.26 percent.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0, implementing grammar parsing support for parts. Tracked as CRAFT-820, the change passes all tests and increases overall coverage by 0.26% with 77.01% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1817 grammar: support strings snapcraft merged Merged PR #1817 in commit 574cd766d, adding generic grammar processing for string values and enabling it for source, resolving #1686 and #1687.
72%
#1511 project_loader: support grammar on build-packages snapcraft merged Merged as commit 4674a5738, adding grammar support for build-packages globally and per part after prerequisite #1509.
71%
#1684 Vendor grammar logic into snapcraft snapcraft closed Advanced grammar was extracted to craft-grammar and adopted by Snapcraft in #3642 (merge 943d130c2), superseding the planned in-tree refactor.
70%