Update test_lxd.py
Metadata
Current evaluation
PR #1820's test cleanup was closed unmerged after a reviewer noted it did not increase LXD test coverage; no resolving commit or replacement was identified.
Resolution: closed stale
Reason: On 2017-12-19, maintainer @kyrofa questioned whether the change advanced the coverage task, and the PR was later closed unmerged. No resolving commit, merge, or replacement PR was found.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #1820's test cleanup was closed unmerged after a reviewer noted it did not increase LXD test coverage; no resolving commit or replacement was identified. | |
| stealth/space-bunny-alpha | — | closed stale | PR #1820 was closed unmerged after a reviewer said its test cleanup did not increase coverage; no resolving commit or replacement PR was identified. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The contributor simplified an existing test by removing a redundant conditional, but the reviewer noted it failed to fulfill the original goal of writing a new unit test to increase coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Reviewers declined the changes because they refactored existing logic without increasing test coverage, conflicting with the GCI task requirements for new unit tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5273 test: use lxd for python symlink tests, update craft-parts | snapcraft | closed | PR #5273 was closed unmerged after its LXD and craft-parts test changes still produced intermittent Python symlink failures; no resolving commit landed. | |
| #207 tests: split lxd integration tests | craft-providers | merged | Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca. | |
| #863 Fix LXD integration test failures by configuring required remotes | craft-providers | closed | PR #863 was closed unmerged after its LXD remote fixture in commit 6c22337 still failed Linux integration and CLA checks; no main-branch resolution was found. | |
| #606 tests: update LXD error message | craft-providers | merged | Merged PR #606 updated an LXD integration test’s expected error message after a progressive LXD snap release changed the output. | |
| #179 test: drop tests for lxd 6 on focal | starflow | closed | PR #179 closed without a recorded merge: it removed one LXD 6/Focal test line and passed all CI checks. | |
| #1807 tests: run test_cleanbuild in LXD on Travis | snapcraft | merged | Merged PR #1807 (commit 70df69b9a) by kalikiana, making test_cleanbuild run in LXD on Travis so it is no longer skipped when tests run as a snap; fixes LP #1738210. Reviewer asked to revert the last commit keeping LXD for cleanbuild only. | |
| #2983 tests: add LXD spread test | snapcraft | merged | Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred. |