tests: run test_cleanbuild in LXD on Travis
Metadata
Current evaluation
Merged PR #1807 (commit 70df69b9a) by kalikiana, making test_cleanbuild run in LXD on Travis so it is no longer skipped when tests run as a snap; fixes LP #1738210. Reviewer asked to revert the last commit keeping LXD for cleanbuild only.
Resolution: closed resolved
Reason: The PR was merged as commit 70df69b9a with maintainer approval from sergiusens, landing the runtests.sh/Travis changes so test_cleanbuild executes in an LXD container instead of being skipped. It explicitly declares "Fixes: LP #1738210" and the final review comment directed a revert of the extra commit, which was applied before merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Attempt to sort out test_cleanbuild being skipped in #1803 when run as a snap
Fixes: [LP: #1738210](https://bugs.launchpad.net/snapcraft/+bug/1738210)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1807 (commit 70df69b9a) by kalikiana, making test_cleanbuild run in LXD on Travis so it is no longer skipped when tests run as a snap; fixes LP #1738210. Reviewer asked to revert the last commit keeping LXD for cleanbuild only. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1807 (commit 70df69b9a), enabling test_cleanbuild to run in LXD on Travis and fixing its skip when tests ran as a snap; addressing LP #1738210. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following CI errors and reviewer feedback. Adjusted to run test_cleanbuild in LXD on Travis, reverting a problematic commit to isolate the cleanbuild fix. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after reverting a commit that broke test_container_builds. The final implementation configures Travis to run test_cleanbuild in LXD, resolving the skipped test issue when executed as a snap. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#1803
(confidence 70%)
PR #1803 (commit ab0075160, 'ci: correctly run from snap') is the follow-up whose hidden skips/failures this PR addresses for test_cleanbuild
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1738210 container tests broken in travis when running from a snap | snapcraft (launchpad) | closed | Travis cleanbuild tests were fixed by running them in LXD, merged in snapcore/snapcraft#1807 (commit 70df69b9a). | |
| #1415 tests: run the tests in travis using LXD containers | snapcraft | merged | Merged in snapcraft#1415 via commit 8c9a38cde, updating Travis CI to run the test suite in LXD containers. | |
| #327 Clean up the lxc building in travis | snapcraft | merged | Merged as snapcraft#327 (merge 4f342a6b9, commit 026100eed "travis: clean up the lxd script"), simplifying the Travis LXC build after a rebase; kyrofa approved. Its follow-up bugfix landed in #340. | |
| #1411 tests: build the snapcraft snap in travis tests | snapcraft | merged | Merged #1411 via commit 92c1e43b1, adding Travis coverage that builds the Snapcraft snap after LXD test infrastructure landed in #1415. | |
| #2149 travis: use LXD from 3.0 track | snapcraft | merged | Merged PR #2149 via commit 0b84e215c, moving Travis to LXD's 3.0 track and removing obsolete testbr0 setup after LXD networking changes broke CI. | |
| #3725 tests: use lxd in clean provider test | snapcraft | merged | Merged PR #3725 (commit 61aaff6fc) into snapcraft/7.0, enabling LXD in provider-cleaning unit tests so they match destructive-mode test runs. Approved by one maintainer reviewer. | |
| #207 tests: split lxd integration tests | craft-providers | merged | Merged #207 to split LXD integration tests, resolving review feedback from #205; landed as commit 3eba5ca. | |
| #2557 ci: remove dependency on LXD from travis tests | snapcraft | merged | Merged PR #2557 as commit c541fac1d, removing LXD setup and container execution from Travis tests to reduce networking errors. | |
| #1820 Update test_lxd.py | snapcraft | closed | PR #1820's test cleanup was closed unmerged after a reviewer noted it did not increase LXD test coverage; no resolving commit or replacement was identified. | |
| #2148 travis: stop setting up testbr0 for lxd | snapcraft | closed | PR #2148 (drop testbr0 network setup in .travis.yml) was closed unmerged; maintainer kyrofa preferred pinning LXD to the 3.0 track instead. Superseded by merged PR #2149, commit 0b84e215c. |