← Back to issue list

tests: skip classic confined tests on armhf

View original Github issue

Metadata

Project
snapcraft
Number
#1822
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Skips classic confined tests on armhf architecture because a snapcraft deb requirement to install patchelf from the snapstore disabled them. Approved by one reviewer and merged with a +14/-6 change across seven files.

Suggested action:

No scores available.

Issue body

We recently added a requirement to the snapcraft deb to install patchelf from the snapstore which disabled a couple of tests. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Skips classic confined tests on armhf architecture because a snapcraft deb requirement to install patchelf from the snapstore disabled them. Approved by one reviewer and merged with a +14/-6 change across seven files.
qwen3.6-35b-a3b-mtp-q6 Merged changes to skip classic confined tests on armhf architecture. The update addresses test failures caused by a snapcraft deb requirement to install patchelf from the snapstore. All static and unit checks passed.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to skip classic confined tests on armhf. A snapcraft deb requirement to install patchelf from the snapstore disabled these tests. The change excludes them to prevent suite failures on armhf.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#990 tests: fix snaps tests in armhf snapcraft merged Merged into master to fix failing snap tests on the armhf architecture. Approved by a reviewer, the change updated 11 files and resolved CI failures without altering overall code coverage.
79%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.
78%
#1430 tests: enable the snaps installation in armhf snapcraft closed Enabling snaps installation in armhf tests was closed by a maintainer. Citing the work as stale and non-functional, the changes were abandoned and not merged.
74%
#1431 tests: do not check the opencv command if it wasn't installed snapcraft merged Merged a test fix skipping opencv command checks when the package is absent. Approved by one reviewer, it changes one file (+15/-14) to prevent failures without opencv. Unrelated armhf snap issues remain open.
72%
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
72%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
71%
#971 tests: fix integration tests in armhf snapcraft merged Merged to master after approval and passing CI. The patch fixes integration tests on armhf architecture. Reviewers approved the change but recommended using project_options over platform.machine for future architectural consistency. Code coverage remained stable at 96.39%.
71%
#5248 ci: publish snaps to arm64 snapcraft merged Merged CI updates to build and publish test snaps for arm64. Approved by two reviewers with passing checks, the change enables automated testing for related snapcraft and craft-providers issues.
70%