← Back to issue list

cmake plugin: update plugin details

View original Github issue

Metadata

Project
snapcraft
Number
#1832
Type
pull request
State
merged
Author
konrad11901
Labels
Created
Updated
Closed

Current evaluation

Merged documentation update adding make plugin keywords to the cmake plugin, resolving bug #1647931. Approved and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Updates the cmake plugin details to include the information about the keywords from the make plugin. Fixes [#1647931](https://bugs.launchpad.net/snapcraft/+bug/1647931).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged documentation update adding make plugin keywords to the cmake plugin, resolving bug #1647931. Approved and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged update to cmake plugin documentation adding make plugin keywords, resolving bug #1647931. Contributor incorporated feedback and tests passed prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged external contribution updating cmake plugin documentation to include make plugin keywords, resolving bug 1647931. Plugin details now align with make plugin functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#713 feat(docs): cmake plugin reference craft-parts merged Merged addition of a CMake plugin reference to the documentation. Approved by two reviewers with passing CI checks, modifying two files with 87 additions and 87 deletions.
77%
#1645 docs: fix cmake plugin ref in parts explanation craft-parts merged Merged a documentation update correcting a cmake plugin reference in the parts explanation. The PR addressed reviewer feedback, received approval, and passed CI checks following a temporary linter failure caused by an external website outage.
75%
#3288 cmake v2 plugin: add help for cmake generators snapcraft merged Merged changes adding help documentation for cmake generators to the cmake v2 plugin. Approved by a reviewer, passed CI checks, and applied successfully.
74%
#724 feat(docs): qmake plugin reference craft-parts merged Merged documentation update adding a qmake plugin reference. The change added 93 lines across two files and was approved by two reviewers before integration.
73%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
71%
#935 cmake plugin: utilize MakePlugin build logic within CMakePlugin snapcraft merged Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter.
70%