plugins: update make plugin to use get_build_properties()
Metadata
Current evaluation
Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c.
Resolution: closed resolved
Reason: PR #992 was approved and merged. Commit 65a1dd09c records the make-plugin API migration and corresponding unit-test updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated make plugin to use get_build_properties().
Updated test_plugin_make as well to test this method.
https://bugs.launchpad.net/snapcraft/+bug/1650548
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 65a1dd09c: the make plugin now uses get_build_properties(), with updated tests resolving Launchpad bug #1650548. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master: the make plugin was updated to use get_build_properties(), with corresponding tests added, via snapcraft#992 (commit 65a1dd09c). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates the make plugin and its tests to use get_build_properties(), resolving Launchpad bug #1650548. Changes pass code coverage checks and integrate successfully. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #991 Updated ant plugin to use get_build_properties() | snapcraft | merged | Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly. |