plugins: update make plugin to use get_build_properties()
Metadata
Current evaluation
Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
Suggested action: —
No scores available.
Issue body
Updated make plugin to use get_build_properties().
Updated test_plugin_make as well to test this method.
https://bugs.launchpad.net/snapcraft/+bug/1650548
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates the make plugin and its tests to use get_build_properties(), resolving Launchpad bug #1650548. Changes pass code coverage checks and integrate successfully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the make plugin and tests to use get_build_properties(), resolving Launchpad bug #1650548. The change, contributed by ZenHarbinger, achieved 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged into master. Updates the copy plugin to use get_build_properties(), replacing deprecated properties and completing Launchpad bug #1647899. The change spans two files with a +17/-4 line diff and achieved 100% diff coverage. | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged update to the kernel plugin switching it to get_build_properties(), resolving Launchpad bug #1650597. Approved by one reviewer, passed CI, and modified four files with a net coverage increase. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #983 Updated scons plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. |