cmake plugin: utilize MakePlugin build logic within CMakePlugin
Metadata
Current evaluation
Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter.
Suggested action: —
No scores available.
Issue body
The CMakePlugin inherits from MakePlugin but ignores all of the interesting customization available in the MakePlugin. This commit breaks some of the build logic for make into a separate method such that it can be called during a cmake build.
Also See: https://bugs.launchpad.net/snapcraft/+bug/1645853
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Refactors MakePlugin build logic into a reusable method, allowing CMakePlugin to leverage existing customization. Approved by two reviewers, modified four files (+51/-31 lines), and added tests for the optional env parameter. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Extracts MakePlugin build logic into a reusable method so CMakePlugin can leverage existing customizations. Coverage drops were resolved by removing obsolete code, making the env parameter optional, and adding tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Refactors MakePlugin build logic into a reusable method for CMakePlugin. Added an optional env parameter to make, updated tests, and removed obsolete code. Addressed review feedback and merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. | |
| #3037 plugins: introduce v2.CMakePlugin | snapcraft | merged | Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions. | |
| #3032 plugins: introduce v2.MakePlugin with rebuilding | snapcraft | merged | Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines). | |
| #3069 make v2 plugin: make use of make-parameters | snapcraft | merged | Merged the make v2 plugin update to utilize make-parameters. The change adds 59 lines and removes 8 across five files, successfully integrating the feature into the codebase. | |
| #1832 cmake plugin: update plugin details | snapcraft | merged | Merged documentation update adding make plugin keywords to the cmake plugin, resolving bug #1647931. Approved and passed CI checks. | |
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files. |