← Back to issue list

schema: sync patterns with snapd

View original Github issue

Metadata

Project
snapcraft
Number
#1622
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1622 in commit 066d6e757, aligning snap and hook name schema patterns with snapd and improving jsonschema error handling; fixes LP #1693798.

Resolution: closed resolved

Reason: PR #1622 was merged as commit 066d6e757. It synchronized snap and hook name patterns with snapd and addressed LP bug #1693798.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- The snap name and hook name patterns got out of sync. This PR fixes LP: [#1693798](https://bugs.launchpad.net/snapcraft/+bug/1693798) by getting them back in sync. It also updates the jsonschema error handling to be more readable.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1622 in commit 066d6e757, aligning snap and hook name schema patterns with snapd and improving jsonschema error handling; fixes LP #1693798.
stealth/space-bunny-alpha — closed resolved Merged PR #1622 in commit 066d6e757, aligning snap and hook name patterns with snapd and improving jsonschema error handling; fixes LP #1693798.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1622 (commit 066d6e757), aligning snap and hook name schema patterns with snapd to fix LP #1693798; JSON Schema error handling was also clarified.
qwen/qwen3.6-35b-a3b — — Synced snap name and hook name patterns with snapd, resolving LP bug #1693798. Improved jsonschema error handling readability. Merged after reviewer approval and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged updates synchronizing snap name and hook name patterns with snapd, resolving Launchpad bug #1693798. Jsonschema error handling readability was also improved.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2627 synchronizing snapd supported schema to snapcraft snapcraft merged Merged in snapcore/snapcraft#2627 (5534fe3d), synchronizing Snapcraft’s schema with snapd’s supported daemon and app fields and validation patterns.
75%
#2448 Swap yaml schema document with json equivalent snapcraft merged PR #2448 merged as commit 2a2f798d0 ("schema: convert yaml jsonschema document to a json equivalent"), replacing schema/snapcraft.yaml with schema/snapcraft.json and adjusting validation error formatting.
72%
#2609 schema: allow 'snapd' snap type snapcraft merged Merged in snapcraft#2609 via commit b2c510f8b, adding “snapd” as an allowed snap type in the schema.
71%
#1924 schema: update version regex snapcraft merged Merged PR #1924 (commit 818eb0390) updated the schema version-validation regex to match snapd and the review tools.
71%
#2446 Update schema/snapcraft.yaml snapcraft closed PR #2446 edited schema/snapcraft.yaml to aid yaml-to-json converters but was closed unmerged in favour of #2448, which replaced the YAML schema with snapcraft.json (commit 2a2f798d0).
70%