← Back to issue list

elf: contemplate more patching scenarios

View original Github issue

Metadata

Project
snapcraft
Number
#1935
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Added support for building classic confined snaps on older releases like bionic and enabling snapcraft hooks. Approved, passed CI, and integrated successfully.

Suggested action:

No scores available.

Issue body

Includes support for building classic confined snaps on release like bionic that target a 16 base and also adds support for using hooks built with snapcraft. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Added support for building classic confined snaps on older releases like bionic and enabling snapcraft hooks. Approved, passed CI, and integrated successfully.
qwen3.6-35b-a3b-mtp-q6 Merged ELF patching updates for classic confined snaps on Ubuntu Bionic targeting 16 base and snapcraft-built hooks. CI passed and type hints were resolved prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged after passing tests and resolving a type annotation error. Adds ELF patching support for classic confined snaps on Ubuntu 18.04 targeting 16.04 bases and snapcraft-built hooks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#949 project: support building classic snaps snapcraft merged Added support for building classic snaps by configuring core snap paths. Reviewer feedback on architecture-specific linker paths was addressed, and the changes were approved and merged into master.
72%
#2081 elf: patch everything instead of a subset of elf files snapcraft merged Merged a pull request that restores Snapcraft 2.39 behavior by patching all ELF files instead of a subset, reverting a prior change. Approved and passed CI.
72%
#8 feat: support build-packages snapcraft-rocks merged Merged a feature adding a wrapper script to run apt update before Snapcraft, resolving an empty Apt cache issue in the base Ubuntu image. Approved by reviewers and rebased to pass tests before merge.
71%
#5085 fix: allow parallel installations of signed snapcraft snaps snapcraft merged Merged a fix enabling parallel installations of signed snapcraft snaps, resolving issues #4683 and #4927. Approved by two reviewers, passed CI checks, and integrated.
70%