snap: correct patch apply for patchelf
Metadata
Current evaluation
Merged a two-line fix correcting patch application for patchelf. Approved by a reviewer, passed CI, and merged to master. An unrelated test failure was noted but disregarded to proceed.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
-------
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a two-line fix correcting patch application for patchelf. Approved by a reviewer, passed CI, and merged to master. An unrelated test failure was noted but disregarded to proceed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrects patch application logic for patchelf in snap packaging. Code coverage unchanged. Proceeded despite an unrelated core20 test failure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrects patch application logic for patchelf in snap packaging. Code coverage unchanged. Merge proceeded despite an unrelated core20 test failure. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3588 snap: patch patchelf on riscv64 (CRAFT-566) | snapcraft | merged | Merged to master. Conditionally applies patchelf patches on riscv64 to prevent breaking other architectures. Approved by one reviewer, passed CI, and added 104 lines across three files without impacting test coverage. | |
| #1983 snap: update revision of patchelf to use | snapcraft | closed | Closed without merging. The patchelf revision update received no reviews, comments, or CI checks, indicating it was abandoned or superseded by a later change. | |
| #3841 elf: add elf file patcher | snapcraft | merged | Merged an ELF file patcher using patchelf, ported from Snapcraft 6.x. Approved by one reviewer, passed CI checks, and increased test coverage by 0.26%. Resolves CRAFT-1191. | |
| #1873 elf: cleaner patchelf experience | snapcraft | merged | Merged improvements to patchelf handling. The change uses the system patchelf by default, copies files to prevent hard-link conflicts, and provides fallback instructions. Approved by two reviewers and passed CI checks before merging. | |
| #1888 elf: make patchelf a dependency | snapcraft | merged | Merged after reviewer approval and CI checks. The change corrects patchelf handling by removing it from build_tools and properly configuring it as a dependency via debian/control for deb packages and snapcraft bundling for snaps. | |
| #4003 Tests: Make test_patcher not require a real patchelf in /usr/bin | snapcraft | merged | Merged into main. Updates test_patcher to remove the dependency on a system patchelf binary in /usr/bin, resolving a PATH ordering issue. Approved, passed CI, and increased test coverage by 0.61%. | |
| #2081 elf: patch everything instead of a subset of elf files | snapcraft | merged | Merged a pull request that restores Snapcraft 2.39 behavior by patching all ELF files instead of a subset, reverting a prior change. Approved and passed CI. | |
| #2528 packaging: use our patchelf branch | snapcraft | merged | Merged into master to fix s390x build failures by switching patchelf to a custom branch with a failing test disabled. The one-line change was approved, passed CI, and integrated. | |
| #5486 build: add patchelf to make dependencies | snapcraft | merged | Merged to add patchelf to development environment dependencies, resolving test failures on self-hosted runners. Approved by two reviewers and passed CI checks. | |
| #4639 feat: enable patchelf for core24 | snapcraft | merged | Enabled patchelf for core24. Merged after approval from two reviewers and passing CI checks. The change updates six files (+75/-9 lines) with full test coverage on modified code. |