Catkin plugin: Improve cmake path rewrite.
Metadata
Current evaluation
Merged #195 via 0bb02b679 (merge commit 42b5e382c), replacing hard-coded Catkin Config.cmake paths with generic, robust rewrites to the install directory.
Resolution: closed resolved
Reason: PR #195 was merged with implementation commit 0bb02b679, which generalized Catkin CMake config path rewrites. Merge commit 42b5e382c records the integration.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Currently the Catkin plugin prepares to build by rewriting the Catkin <package>Config.cmake files from the ROS Ubuntu packages to point to the install directory instead of system paths. However, it was hard-coded to only rewrite a specific path, and misses others. This PR makes the path rewrites more generic and robust.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #195 via 0bb02b679 (merge commit 42b5e382c), replacing hard-coded Catkin Config.cmake paths with generic, robust rewrites to the install directory. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #195 (commit 0bb02b679), replacing hard-coded Catkin Config.cmake path rewrites with generic, robust install-directory rewrites. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#195, replacing hard-coded Catkin Config.cmake paths with more generic, robust rewrites to the install directory. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #195 generalized Catkin CMake path rewrites, replacing hard-coded paths so ROS package Config.cmake files reliably point to the install directory. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the Catkin plugin that replace hard-coded cmake path rewrites with a generic, robust approach. The change modifies two files to correctly redirect ROS package Config.cmake files to the install directory. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request that replaces hard-coded path rewrites in the Catkin plugin with a generic, robust solution for updating ROS Config.cmake files to point to the install directory. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. | snapcraft | merged | Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory. | |
| #175 Catkin plugin: Refactor build. | snapcraft | merged | Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests. | |
| #2847 Catkin plugin: consider only 'local' workspaces | snapcraft | merged | Merged PR #2847 (commit 1d476f622) sources ROS setup with --local, preventing destructive-mode Catkin builds from using host workspaces and skipping dependency installation. | |
| #2546 [legacy] catkin plugin: ensure cxxflags are consistent | snapcraft | merged | Merged PR #2546 into legacy, making catkin include paths deterministic so CXXFLAGS stay stable between builds and avoid unnecessary rebuilds (LP: #1827148). | |
| #2972 catkin plugins: remove bash workaround for catkin cmake args | snapcraft | merged | Merged in #2972 as commit 9b8446902, replacing Bash-based catkin CMake argument handling with shlex.split() and adding coverage for quoting variants. |