Catkin plugin: Improve cmake path rewrite.
Metadata
Current evaluation
Merged updates to the Catkin plugin that replace hard-coded cmake path rewrites with a generic, robust approach. The change modifies two files to correctly redirect ROS package Config.cmake files to the install directory.
Suggested action: —
No scores available.
Issue body
Currently the Catkin plugin prepares to build by rewriting the Catkin <package>Config.cmake files from the ROS Ubuntu packages to point to the install directory instead of system paths. However, it was hard-coded to only rewrite a specific path, and misses others. This PR makes the path rewrites more generic and robust.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the Catkin plugin that replace hard-coded cmake path rewrites with a generic, robust approach. The change modifies two files to correctly redirect ROS package Config.cmake files to the install directory. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request that replaces hard-coded path rewrites in the Catkin plugin with a generic, robust solution for updating ROS Config.cmake files to point to the install directory. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer PR that replaces hard-coded path rewriting in the Catkin plugin with a generic, robust solution to correctly redirect all Catkin packageConfig.cmake files to the install directory. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled. | |
| #842 Catkin plugin: Support ROS Kinetic. | snapcraft | merged | Merged. Adds ROS Kinetic support to the Catkin plugin by refactoring source handling for extensibility and mapping ROS to Ubuntu releases. Fixed a fileutils coverage gap during review. Approved and merged. | |
| #196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. | snapcraft | merged | Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35). | |
| #1130 catkin plugin: produce build-ready staging area. | snapcraft | merged | Merged update to the Catkin plugin generating a build-ready staging area by adjusting ROS files post-build, resolving LP #1663385. Approved, passed CI, and modified two files to prevent future parts from referencing the old install directory. | |
| #175 Catkin plugin: Refactor build. | snapcraft | merged | Merged after addressing reviewer feedback on error handling and testing strategy. The update refactored the Catkin plugin build process, simplified build logic, extracted dependency resolution, added a source-space keyword, and achieved 100% unit test coverage. | |
| #163 Catkin plugin: use rosdep for dependency resolution | snapcraft | merged | Merged. Replaced manual package.xml parsing with rosdep for Catkin plugin dependency resolution. Reviewers approved the changes, with minor naming suggestions deferred to a future refactor. | |
| #2007 catkin plugin: replace python calls in all profile.d scripts | snapcraft | merged | Merged update to the catkin plugin replacing absolute Python paths with python in all etc/catkin/profile.d scripts. Fixes broken ROS Kinetic snaps on Ubuntu Core after upstream changes and resolves Catkin Tools plugin issues. | |
| #1314 catkin plugin: add support for rosinstall files | snapcraft | merged | Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735. | |
| #2847 Catkin plugin: consider only 'local' workspaces | snapcraft | merged | Merged. Fixes catkin plugin dependency resolution in destructive mode by passing the --local flag when sourcing ROS setup scripts. This prevents host ROS paths from leaking into workspace searches. Approved by three reviewers. | |
| #1367 catkin plugin: add support for ROS Lunar | snapcraft | merged | Merged the catkin plugin update to support ROS Lunar alongside Indigo, Jade, and Kinetic. CI initially failed due to a Launchpad bug, resolved by adding lsb-release to build-packages. Approved and merged after passing integration tests. |