← Back to issue list

Backport to 1.x: Catkin plugin: Improve cmake path rewrite.

View original Github issue

Metadata

Project
snapcraft
Number
#196
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.

Resolution: closed resolved

Reason: PR #196 was merged into the 1.x branch. It backports PR #195, implemented by commit 0bb02b679 and merged through 42b5e382c.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #195 to 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin ROS package Config.cmake files correctly target the install directory.
stealth/space-bunny-alpha — closed resolved Merged backport of canonical/snapcraft#195 to 1.x, improving the Catkin plugin’s CMake path rewriting across two files.
qwen/qwen3.6-35b-a3b — — Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #195 to the 1.x branch, improving cmake path rewrite logic in the Catkin plugin. Upstream changes were applied directly to the legacy release line.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling.
86%
#195 Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged #195 via 0bb02b679 (merge commit 42b5e382c), replacing hard-coded Catkin Config.cmake paths with generic, robust rewrites to the install directory.
81%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.
77%
#180 Backport to 1.x: Catkin plugin: Add support for ROS tools. snapcraft merged Merged #180, backporting #152 to the 1.x branch to add ROS tools support to the Catkin plugin.
77%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
76%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.
73%