← Back to issue list

Backport to 1.x: Catkin plugin: Improve cmake path rewrite.

View original Github issue

Metadata

Project
snapcraft
Number
#196
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).

Suggested action: —

No scores available.

Issue body

Backport of #195 to 1.x.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #195 to the 1.x branch, improving cmake path rewrite logic in the Catkin plugin. Upstream changes were applied directly to the legacy release line.
qwen3.6-35b-a3b-mtp-q6 — — Merged a backport of PR #195 to the 1.x branch, improving cmake path rewrite logic in the Catkin plugin. The maintainer integrated the upstream changes directly.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
88%
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
85%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged backport of #163 to the 1.x branch. The catkin plugin now uses rosdep for dependency resolution, updating three files with 547 additions and 147 deletions.
79%
#180 Backport to 1.x: Catkin plugin: Add support for ROS tools. snapcraft merged Merged backport of #152 to the 1.x branch, adding ROS tool support to the Catkin plugin. The update modified four files with 112 additions and 28 deletions, successfully integrating the feature.
76%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
76%
#195 Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged updates to the Catkin plugin that replace hard-coded cmake path rewrites with a generic, robust approach. The change modifies two files to correctly redirect ROS package Config.cmake files to the install directory.
75%
#219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests snapcraft merged Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line.
74%