[legacy] catkin plugin: ensure cxxflags are consistent
Metadata
Current evaluation
Merged fix for the legacy catkin plugin ensuring deterministic include path ordering. Resolves unnecessary rebuilds from non-deterministic cxxflags. Approved, passed CI, and merged.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently some of the include paths aren't ordered deterministically, and they change between builds, which ruins the rebuilding story because Catkin takes it as a sign that it needs to start the build over. This PR fixes [LP: #1827148](https://bugs.launchpad.net/snapcraft/+bug/1827148) for legacy by making sure they stay the same between builds.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for the legacy catkin plugin ensuring deterministic include path ordering. Resolves unnecessary rebuilds from non-deterministic cxxflags. Approved, passed CI, and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into the legacy branch to fix non-deterministic include paths in the catkin plugin that caused unnecessary rebuilds. Resolves LP #1827148. Requires PR #2547 for tests to pass. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the legacy catkin plugin ensuring deterministic cxxflags and include paths. Resolves Launchpad bug #1827148 by preventing unnecessary rebuilds. PR #2547 was required to pass tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2545 catkin plugin: use build-packages for compilers | snapcraft | merged | Merged updates to the Catkin plugin that specify compilers as build-packages instead of isolating them. This resolves a rebuild failure and aligns with current base requirements. Approved by one reviewer and passed CI. | |
| #3168 plugins: fix loading of catkin-tools | snapcraft | merged | Merged a one-line correction changing catkin_tools to catkin-tools in the plugin loader, resolving package loading failures. Approved, passed CI, and addresses LP #1882996. | |
| #1526 catkin plugin: don't assume catkin is in underlay | snapcraft | merged | Merged fix updating the catkin plugin to use its isolated installation instead of assuming catkin exists in the underlay. Resolves Launchpad bug #1696014. Includes reviewer-requested test naming updates. Approved and merged. |