tests: remove dependency on snapcraft for integration tests
Metadata
Current evaluation
Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions.
Suggested action: —
No scores available.
Issue body
The integration tests import snapcraft into the suite, this causes all
sorts of problems, the most concerning one is test independence.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that remove the snapcraft dependency from integration tests to improve test independence. The pull request was successfully integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing snapcraft dependency from integration tests to improve test independence. Accepted despite a Codecov warning regarding missing base commit coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged after two approvals. The PR updates integration tests to run against the installed snapcraft snap, aligning with user environments. Despite a reported Go runtime address space conflict in CI, the changes were accepted and merged. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #73 tests: add stage snaps integration test (CRAFT-68) | craft-parts | merged | Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #2266 integration tests: disable tests using snaps in bionic container | snapcraft | merged | Merged changes disabling integration tests using snaps in bionic containers to address reported failures. The +7/-1 line update across two files passed CI and received reviewer approval. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. |