tests: remove dependency on snapcraft for integration tests
Metadata
Current evaluation
PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup.
Resolution: closed resolved
Reason: The pull request was approved and merged into master as commit 6a7c860c4 ('tests: remove dependency on snapcraft for integration tests (#2353)'), which appears in the tests/integration history. The change is self-contained test refactoring with no follow-up fixes indicated.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The integration tests import snapcraft into the suite, this causes all
sorts of problems, the most concerning one is test independence.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2353 removed Snapcraft imports from integration tests, making the test suite independent. Resolved by commit 6a7c860c4. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that remove the snapcraft dependency from integration tests to improve test independence. The pull request was successfully integrated into the main branch. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2339
(confidence 60%)
Adjacent bases cleanup: lifecycle switched to multipass by default just before this commit (f2cdc5e8a schema deprecation #2344 and #2335 lxd removal follow), the same legacy-teardown series.
-
Related To:
snapcraft#3242
(confidence 55%)
Later continued the same direction: 'tests: migrate legacy classic patchelf tests to spread' (e76a07747), eventually removing the legacy integration suite.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #123 tests: remove snapcraft:core | craft-providers | merged | Merged PR #123 (commit 0cffc84, merged in ba78ce4) deleted the obsolete `snapcraft:core` integration test entry and added `snapcraft:devel`, since Multipass removed the core image. | |
| #1972 tests: remove _options dependency from integration suite | snapcraft | merged | Merged PR snapcraft#1972 (commit b250e330a) by maintainer come-maiz, dropping the last _options import from the integration test suite; follow-up to #1965 which had missed it. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1609 tests: remove the duplicate nodejs integration tests | snapcraft | merged | Merged in snapcraft#1609 via commit d0be68b68, removing duplicate Node.js integration tests already covered by unit tests for npm as the default. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable. |