← Back to issue list

many: use packaging logic to get patchelf

View original Github issue

Metadata

Project
snapcraft
Number
#2006
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2006 in commit aa2a40322, replacing separate patchelf retrieval with shared packaging logic so snap and deb builds use the same version.

Resolution: closed resolved

Reason: PR #2006 was approved and merged as commit aa2a40322. The change routes patchelf acquisition through shared packaging logic, aligning the version used by snap and deb builds.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Also use the same version in the snap and the deb. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2006 in commit aa2a40322, replacing separate patchelf retrieval with shared packaging logic so snap and deb builds use the same version.
stealth/space-bunny-alpha — closed resolved Merged PR #2006 (commit aa2a40322) replaced patchelf retrieval with shared packaging logic, ensuring snap and deb builds use the same patchelf version.
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval and CI checks. Refactored patchelf retrieval to use shared packaging logic, aligning its version across snap and deb packages. Modified four files with a net reduction of 24 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Unified patchelf retrieval via packaging logic to enforce identical versions across snap and deb builds. Integrated by maintainer sergiusens with no additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2528 packaging: use our patchelf branch snapcraft merged Merged (commit bd26cafd6, squashed merge of #2528): snapcraft.yaml now points patchelf sources at Snapcore's own patchelf branch with the failing s390x test disabled, unblocking s390x package builds; later reverted by #2531.
76%
#1888 elf: make patchelf a dependency snapcraft merged Merged PR #1888 via commit 7c947f5ec, moving Patchelf out of project_loader build tools and into the deb and snap delivery mechanisms.
76%
#1983 snap: update revision of patchelf to use snapcraft closed Closed unmerged; the bundled PatchELF revision bump in #1983 was superseded by #2006, which adopted packaging-based acquisition (commit aa2a40322).
74%
#2519 packaging: use local patchelf snapcraft merged Merged as e39d2404c, adopting Patchelf 0.10 and relinking dynamic Go executables; later reverted by #2531 after architecture tests exposed unreliable binaries.
74%
#1873 elf: cleaner patchelf experience snapcraft merged Merged as df6992224: Snapcraft now prefers system Patchelf outside snaps and copies target files to avoid hard-link patching conflicts.
73%
#3589 snap: correct patch apply for patchelf snapcraft merged Merged PR #3589 fixed PatchELF patch application in the snap build via commit d9484faf9 (merge a636d26b5).
72%
#1967 project_loader: improve the logic to install patchelf as a build tool snapcraft merged Merged PR #1967 as commit 84aaac591, improving patchelf build-tool installation and excluding broken Xenial armhf/s390x packages.
71%
#2081 elf: patch everything instead of a subset of elf files snapcraft merged Merged PR #2081 restored Snapcraft 2.39 behavior by patching every ELF file; commit 77770452b partially reverted 64f78f762a05.
71%
#1935 elf: contemplate more patching scenarios snapcraft merged Merged PR #1935 as 048adc4a3, adding ELF patching for classic snaps built on bionic targeting core16 and for hooks built with Snapcraft.
71%
#1669 patchelf with ld-linux from the future snapcraft closed Resolved by commit bdaf0b7f1, which added Snapcraft handling for PatchELF and ELF files when the built glibc/linker does not match the base.
70%