← Back to issue list

kernel plugin: add kmod as build-package

View original Github issue

Metadata

Project
snapcraft
Number
#2041
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2041 as commit 327552751, adding kmod to kernel-plugin build packages and /sbin to PATH so modprobe is available during Launchpad builds.

Resolution: closed resolved

Reason: PR #2041 was merged into Snapcraft as commit 327552751. It fixes Launchpad bug #1759592 by ensuring the modprobe dependency is installed and discoverable.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Currently, in some cases, the kernel plugin shells out to modprobe. However, it doesn't ensure modprobe is actually present, which it isn't in the Launchpad builders. This PR fixes LP: [#1759592](https://bugs.launchpad.net/snapcraft/+bug/1759592) by adding kmod as a build-package to ensure modprobe is always available. `/sbin` is also added to the PATH, in case it's not already there.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2041 as commit 327552751, adding kmod to kernel-plugin build packages and /sbin to PATH so modprobe is available during Launchpad builds.
stealth/space-bunny-alpha — closed resolved Merged as commit 327552751, adding kmod to kernel plugin build packages and /sbin to PATH so modprobe is available in Launchpad builds.
stealth/space-bunny-alpha — closed resolved Merged PR #2041 as commit 327552751, adding kmod as a kernel-plugin build package and /sbin to PATH so modprobe is available in Launchpad builds.
qwen/qwen3.6-35b-a3b — — Merged a kernel plugin fix adding kmod as a build dependency and /sbin to PATH. This resolves missing modprobe errors in Launchpad builders by ensuring required tools are available during snap builds.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix adding kmod as a build dependency and /sbin to PATH in the kernel plugin. This ensures modprobe availability during builds, resolving Launchpad builder failures tracked in LP: #1759592.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1759592 kernel build fails for lack of modprobe snapcraft (launchpad) closed Kernel builds on Launchpad failed because modprobe was missing. Fixed by snapcore/snapcraft PR #2041, merged as commit 327552751, adding kmod to the kernel plugin's build-packages (plus /sbin on PATH); LP bug closed as fixed.
76%
#1208 kernel plugin: fix modprobe output parsing. snapcraft merged Merged in #1208 via commit 6c8d85ee3, fixing kernel-plugin modprobe parsing to take the module path from the second output item and addressing LP #1675029.
71%
#4185 kernel plugin: add debhelper build dependency snapcraft merged Merged PR #4185 in commit 389462c51, adding debhelper as a kernel-plugin build dependency required by debian/rules clean.
71%
#837 kernel plugin: allow collecting the same mod deps snapcraft merged Merged PR #837 in commit 2e9e4b667, deduplicating kernel-module dependencies with a set so shared dependencies are not copied twice into the initrd.
70%