kernel plugin: allow collecting the same mod deps
Metadata
Current evaluation
Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines.
Suggested action: —
No scores available.
Issue body
If modules end up having the same dependencies they would
of been copied twice, this transforms it into a set to
avoid duplicates.
LP: #1627923
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the kernel plugin that prevents duplicate module dependencies from being copied multiple times by converting the collection to a set. Resolves LP: #1627923. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a kernel plugin fix that prevents duplicate module dependencies from being copied twice by converting the collection to a set. Resolves LP: #1627923. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4081 Kernel plugin improvements 1 | snapcraft | merged | Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines. | |
| #3998 Kernel plugin: multiple fixes | snapcraft | merged | Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks. | |
| #1208 kernel plugin: fix modprobe output parsing. | snapcraft | merged | Merged by maintainer sergiusens to fix modprobe output parsing in the kernel plugin. The change correctly identifies the module path as the second output item. A failing test was explicitly ignored during merge. | |
| #4053 plugins: extract common code from kernel plugins | snapcraft | merged | Merged after extracting and normalizing common functions from legacy v2 and craft-parts kernel plugins, reducing code by over 700 lines across five files. Review approved. Author addressed feedback by reverting an unnecessary codespell pin commit. | |
| #476 kernel plugin: iterate over modules to add to initrd | snapcraft | merged | Merged updates to the kernel plugin that iterate over modules for initrd inclusion. Approved by @kyrofa following successful tests. Resolves LP #1572118 with 36 additions and 6 deletions across two files. | |
| #4116 plugins: kernel: remove use of deprecated config.common.ports config | snapcraft | merged | Merged removal of deprecated config.common.ports usage from the Ubuntu kernel plugin to prevent future build failures. Approved by reviewers, passed CI, and modified 3 files. | |
| #1115 kernel plugin: fix kernel snap layout | snapcraft | merged | Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification. | |
| #1867 kernel plugin: remove dependency on magic | snapcraft | merged | Removed the magic library dependency from the kernel plugin. Merged after reviewer approval and CI validation. Verified by kyrofa and resolves Launchpad bug #1742504, reducing code by 42 lines across two files. | |
| #1150 kernel plugin: rework MAKEFLAGS from the environment | snapcraft | merged | Merged. The kernel plugin now strips the MAKEFLAGS environment variable to prevent nested Makefile conflicts. Approved by a reviewer, passes CI, and resolves LP #1665661. | |
| #4111 plugins: merge kernel plugin | snapcraft | merged | Merged craft-parts and v2 kernel plugins from a feature branch into main. Approved by one reviewer, passed CI checks, and updated 27 files. Codecov reported a 0.12% coverage increase with 98.32% diff coverage. |