kernel plugin: allow collecting the same mod deps
Metadata
Current evaluation
Merged PR #837 in commit 2e9e4b667, deduplicating kernel-module dependencies with a set so shared dependencies are not copied twice into the initrd.
Resolution: closed resolved
Reason: PR snapcraft#837 was merged as commit 2e9e4b667. Its set-based dependency collection prevents shared kernel modules from being copied multiple times, resolving LP #1627923.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If modules end up having the same dependencies they would
of been copied twice, this transforms it into a set to
avoid duplicates.
LP: #1627923
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #837 in commit 2e9e4b667, deduplicating kernel-module dependencies with a set so shared dependencies are not copied twice into the initrd. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#837 in commit 2e9e4b667, converting kernel module dependencies to a set so shared dependencies are not copied twice. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the kernel plugin that prevents duplicate module dependencies from being copied multiple times by converting the collection to a set. Resolves LP: #1627923. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1627923
(confidence 98%)
The underlying Launchpad bug reported initrd packaging failure from common module dependencies.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #476 kernel plugin: iterate over modules to add to initrd | snapcraft | merged | Kernel plugin now iterates over required modules when assembling the initrd; PR #476 was merged as commit 53941d2b0, resolving LP #1572118. | |
| #3973 kernel plugin: do not copy extra-modules.conf | snapcraft | merged | Merged to stop copying a missing extra-modules.conf, then reverted by #3998 because it dropped configured initramfs modules; #3998 instead ensured an empty file was always created. | |
| #1627923 kernel plugin initrd packaging fails when kernel modules have common dependencies | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft PR #837, which allowed initrd packaging to handle common kernel-module dependencies without duplicate-copy failures. | |
| #4057 Kernel plugin: reapplying missed fixes | snapcraft | merged | Merged PR #4057 fixed kernel-plugin initramfs handling for empty module lists, wildcard overlays, and UC20 module installation, clarified defaults, and updated tests. | |
| #2041 kernel plugin: add kmod as build-package | snapcraft | merged | Merged PR #2041 as commit 327552751, adding kmod to kernel-plugin build packages and /sbin to PATH so modprobe is available during Launchpad builds. |