snapcraft snap: refactor override-build into a script
Metadata
Current evaluation
PR #2283 merged as commit f9592939a, moving the Snapcraft snap's override-build logic into a script to reduce snapcraft.yaml duplication ahead of self-vendoring.
Resolution: closed resolved
Reason: The approved change was merged as commit f9592939a. It refactored override-build into a script, completing the requested duplication reduction.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
In order to reduce duplication in the snapcraft.yaml as we work toward vendoring snapcraft within itself ([LP: #1793261](https://bugs.launchpad.net/snapcraft/+bug/1793261), refactor the current override-build into a script.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2283 merged as commit f9592939a, moving the Snapcraft snap's override-build logic into a script to reduce snapcraft.yaml duplication ahead of self-vendoring. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2283 as commit f9592939a, extracting the snapcraft snap's override-build logic into a script to reduce snapcraft.yaml duplication ahead of vendoring Snapcraft within itself. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that extracts override-build into a standalone script to reduce snapcraft.yaml duplication and support internal vendoring. Approved by reviewer, passed CI, and modified two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring of the snapcraft snap override-build into a standalone script to reduce duplication in snapcraft.yaml. This supports vendoring snapcraft within itself. Static and unit tests passed prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2103 package: make use of snapcraftctl snapcraft features | snapcraft | merged | Merged in #2103 as commit 60d505347 and shipped in 2.42, replacing prepare/build/install hooks with override-pull/override-build. | |
| #2223 snap: prepare override scripts to allow rebuilding | snapcraft | merged | Merged PR #2223 as commit ebbdd7de2, adding reusable override scripts for ctypes linking and PyYAML patching so the project snap could be rebuilt. | |
| #1601 snapcraft.yaml: don't re-use build dir | snapcraft | merged | Merged PR #1601 (commit 3418912a2) renamed the snapcraft.yaml build scriptlet directory to apt-build, stopping the clash with the 'build' dir created by the apt part's make startup when building from source. | |
| #6228 refactor: migrate sign-build command | snapcraft | merged | Merged PR #6228 as commit 2904d0be2, migrating the sign-build command from Snapcraft's legacy codebase as part of SNAPCRAFT-1320. | |
| #2285 snapcraft snap: vendor legacy snapcraft | snapcraft | merged | Merged in canonical/snapcraft#2285 (commit 5c1ee3b88), vendoring legacy Snapcraft and dispatching no-base projects to it to preserve backward compatibility. | |
| #2160 many: refactor snapcraft.yaml loading out of load_config | snapcraft | merged | Merged PR #2160 refactored raw snapcraft.yaml loading out of load_config, landing as commit 44ae843f3. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged PR #3317 in commit 9c622ecda, making snapcraftctl exit nonzero on build/pull failures and stop override scripts after parent operation errors. | |
| #1894 tests: allow to overwrite the snapcraft install command | snapcraft | merged | Merged PR #1894 as commit 596896be8, adding SNAPCRAFT_INSTALL_COMMAND so integration tests can override Snapcraft installation and skip the preceding build stage. | |
| #2734 SnapcraftError refactoring | snapcraft | merged | SnapcraftError refactoring was merged in canonical/snapcraft#2734 after maintainer approval, updating four files (+279/-26). | |
| #2653 scriplets: run override-pull on update_pull | snapcraft | merged | Merged in snapcraft#2653 (commit ae7ab338e), re-running override-pull scriptlets when pull repeats so snapcraftctl-generated metadata is preserved. |