← Back to issue list

tests: add spread suite for cmake plugin

View original Github issue

Metadata

Project
snapcraft
Number
#2183
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.

Resolution: closed resolved

Reason: The PR was approved and merged into master as commit 51518dbe6. It replaced the existing CMake integration coverage with a Spread suite and closed LP #1783830.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR resolves LP: [#1783830](https://bugs.launchpad.net/snapcraft/+bug/1783830) by moving the plugin and snapd integration tests for the CMake plugin into a Spread suite.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.
stealth/space-bunny-alpha — closed resolved Merged as commit 51518dbe6: adds a Spread suite for the CMake plugin, porting the old plugin and snapd integration tests and resolving LP #1783830.
stealth/space-bunny-alpha — closed resolved PR #2183 merged as commit 51518dbe6, moving the CMake plugin and snapd integration tests into a new Spread suite (tests/spread/plugins/cmake) and resolving LP bug #1783830.
stealth/space-bunny-alpha — closed resolved Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.
stealth/space-bunny-alpha — closed resolved Merged PR #2183 as commit 51518dbe6, moving the CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.
qwen/qwen3.6-35b-a3b — — Merged into master, resolving LP #1783830 by migrating CMake plugin integration tests to a Spread suite. Approved, passed CI, and maintained 91.23% code coverage across 17 modified files.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, resolving LP #1783830 by migrating CMake plugin integration tests to a Spread suite. Code coverage remains unchanged.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1783830 (confidence 100%)

    The PR explicitly resolves the Launchpad task to move CMake plugin tests to Spread.

Related issues

Issue Project State Summary Similarity
#2206 tests: add spread suite for catkin plugin snapcraft merged PR #2206 merged as commit 317d4a03a, converting Catkin plugin and snapd integration tests into a Spread suite and resolving LP bug #1783828.
88%
#2182 tests: add spread suite for autotools plugin snapcraft merged PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825.
86%
#2208 tests: add spread suite for scons plugin snapcraft merged Merged PR #2208 as commit a0d0297fc: added a Spread suite for the SCons plugin and moved its plugin/snapd integration tests there, resolving LP bug #1783843 (+32/-76, 9 files).
86%
#2203 tests: add spread suite for kbuild plugin snapcraft merged Merged into snapcraft master as 67d94bd4 (squashed commit f5d1b1741), adding tests/spread/plugins/kbuild and moving Kbuild plugin integration tests out of the Python unit suite; closes LP bug #1783835.
86%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR #2211 as commit bdaa8ea5, replacing the Ament plugin snapd integration test with a Spread suite and resolving LP #1783827.
85%
#2205 tests: add spread suite for meson plugin snapcraft merged Merged PR #2205 as commit 19c651af4, moving Meson plugin integration tests from Python into a Spread suite and resolving LP #1783837.
85%
#1783830 Move CMake plugin tests to spread snapcraft (launchpad) closed CMake plugin integration tests were converted to Spread in snapcore/snapcraft#2183, commit 51518dbe6.
84%
#2212 tests: add spread suite for ruby plugin snapcraft merged Merged PR snapcore/snapcraft#2212 (commit b7729970a) adds a Spread suite for the Ruby plugin, replacing the Python/snapd integration test; closes LP #1783840.
83%
#2199 tests: add spread suite for copy plugin snapcraft merged Merged PR #2199 (f62504d) moved copy-plugin integration tests into a Spread suite, resolving LP #1783831.
83%
#2210 tests: add spread suite for waf plugin snapcraft merged Merged PR #2210 moved Waf plugin integration tests into a new Spread suite, resolving LP #1783846 in commit 5498d0aba.
79%