← Back to issue list

tests: add spread suite for kbuild plugin

View original Github issue

Metadata

Project
snapcraft
Number
#2203
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft master as 67d94bd4 (squashed commit f5d1b1741), adding tests/spread/plugins/kbuild and moving Kbuild plugin integration tests out of the Python unit suite; closes LP bug #1783835.

Resolution: closed resolved

Reason: PR #2203 was approved and merged into master (67d94bd4cb9be69c0142168bbd488f2cd309fe0e), landing as commit f5d1b1741 "tests: add spread suite for kbuild plugin (#2203)", which created tests/spread/plugins/kbuild. The PR explicitly states it resolves LP: #1783835.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR resolves [LP: #1783835](https://bugs.launchpad.net/snapcraft/+bug/1783835) by moving the plugin integration tests for the Kbuild plugin into a Spread suite.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into snapcraft master as 67d94bd4 (squashed commit f5d1b1741), adding tests/spread/plugins/kbuild and moving Kbuild plugin integration tests out of the Python unit suite; closes LP bug #1783835.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#2203 as 67d94bd4cb9be69c0142168bbd488f2cd309fe0e, moving Kbuild plugin integration tests to Spread and resolving LP #1783835.
qwen/qwen3.6-35b-a3b — — Merged following approval and passing CI. Resolves LP: #1783835 by migrating Kbuild plugin integration tests to a Spread suite across six files, increasing overall coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, introducing a Spread test suite for Kbuild plugin integration tests to resolve Launchpad bug #1783835. The update increased overall code coverage by 0.02%.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2202 (confidence 72%)

    Sibling kbuild plugin fix (b6327b0e4) merged in the same period, touching the same plugin the new spread suite exercises.

  • Related To: snapcraft#2204 (confidence 68%)

    Companion kbuild change (f156050bf, stop modifying kconfigfile) merged alongside, altering behaviour covered by the new spread tests.

Related issues

Issue Project State Summary Similarity
#2183 tests: add spread suite for cmake plugin snapcraft merged Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.
86%
#2182 tests: add spread suite for autotools plugin snapcraft merged PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825.
83%
#2212 tests: add spread suite for ruby plugin snapcraft merged Merged PR snapcore/snapcraft#2212 (commit b7729970a) adds a Spread suite for the Ruby plugin, replacing the Python/snapd integration test; closes LP #1783840.
83%
#1783835 Move KBuild plugin tests to spread snapcraft (launchpad) closed KBuild integration tests were moved to a Spread suite by snapcore/snapcraft PR #2203, recorded as commit f5d1b1741.
82%
#2206 tests: add spread suite for catkin plugin snapcraft merged PR #2206 merged as commit 317d4a03a, converting Catkin plugin and snapd integration tests into a Spread suite and resolving LP bug #1783828.
81%
#2208 tests: add spread suite for scons plugin snapcraft merged Merged PR #2208 as commit a0d0297fc: added a Spread suite for the SCons plugin and moved its plugin/snapd integration tests there, resolving LP bug #1783843 (+32/-76, 9 files).
80%
#2205 tests: add spread suite for meson plugin snapcraft merged Merged PR #2205 as commit 19c651af4, moving Meson plugin integration tests from Python into a Spread suite and resolving LP #1783837.
79%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap.
79%
#2199 tests: add spread suite for copy plugin snapcraft merged Merged PR #2199 (f62504d) moved copy-plugin integration tests into a Spread suite, resolving LP #1783831.
76%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR #2211 as commit bdaa8ea5, replacing the Ament plugin snapd integration test with a Spread suite and resolving LP #1783827.
76%