← Back to issue list

tests: add spread suite for catkin plugin

View original Github issue

Metadata

Project
snapcraft
Number
#2206
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #2206 merged as commit 317d4a03a, converting Catkin plugin and snapd integration tests into a Spread suite and resolving LP bug #1783828.

Resolution: closed resolved

Reason: The PR was merged into master (commit 317d4a03a "tests: add spread suite for catkin plugin (#2206)"), a 37-file change moving the Catkin plugin/snapd integration tests into a Spread suite as tracked by LP #1783828. Related spread suites for ament (#2211) and follow-up catkin spread test fixes followed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR resolves [LP: #1783828](https://bugs.launchpad.net/snapcraft/+bug/1783828) by moving the plugin and snapd integration tests for the Catkin plugin into a Spread suite.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2206 merged as commit 317d4a03a, converting Catkin plugin and snapd integration tests into a Spread suite and resolving LP bug #1783828.
stealth/space-bunny-alpha — closed resolved Merged in #2206 (commit 317d4a03a), moving Catkin plugin and snapd integration tests into a Spread suite and resolving LP #1783828.
stealth/space-bunny-alpha — closed resolved Merged PR #2206 in commit 317d4a03a, moving Catkin plugin and snapd integration tests into a Spread suite and resolving Launchpad bug #1783828.
qwen/qwen3.6-35b-a3b — — Merged migration of Catkin plugin integration tests to a Spread suite, resolving Launchpad bug #1783828. Approved by one reviewer, passed CI, and maintained coverage across 37 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer kyrofa, resolving Launchpad bug 1783828. The change migrates Catkin plugin integration tests to a Spread suite with no impact on code coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2211 (confidence 70%)

    Parallel change adding a spread suite for the ament plugin shortly after.

  • Related To: snapcraft#2221 (confidence 60%)

    Follow-up 'spread: stop running catkin tests on 18.10' touching the same catkin spread tests.

Related issues

Issue Project State Summary Similarity
#2183 tests: add spread suite for cmake plugin snapcraft merged Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830.
88%
#1783828 Move Catkin plugin tests to spread snapcraft (launchpad) closed Catkin plugin integration tests were migrated from Python to a Spread suite by merged PR #2206, commit 317d4a03a.
88%
#2182 tests: add spread suite for autotools plugin snapcraft merged PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825.
86%
#1783829 Move Catkin Tools plugin tests to spread snapcraft (launchpad) closed Catkin Tools integration coverage was migrated from Python to Spread by merged canonical/snapcraft#2206 (317d4a03a); LP #1783829 was later closed as stale housekeeping.
84%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR #2211 as commit bdaa8ea5, replacing the Ament plugin snapd integration test with a Spread suite and resolving LP #1783827.
84%
#2208 tests: add spread suite for scons plugin snapcraft merged Merged PR #2208 as commit a0d0297fc: added a Spread suite for the SCons plugin and moved its plugin/snapd integration tests there, resolving LP bug #1783843 (+32/-76, 9 files).
83%
#2212 tests: add spread suite for ruby plugin snapcraft merged Merged PR snapcore/snapcraft#2212 (commit b7729970a) adds a Spread suite for the Ruby plugin, replacing the Python/snapd integration test; closes LP #1783840.
82%
#2203 tests: add spread suite for kbuild plugin snapcraft merged Merged into snapcraft master as 67d94bd4 (squashed commit f5d1b1741), adding tests/spread/plugins/kbuild and moving Kbuild plugin integration tests out of the Python unit suite; closes LP bug #1783835.
81%
#2199 tests: add spread suite for copy plugin snapcraft merged Merged PR #2199 (f62504d) moved copy-plugin integration tests into a Spread suite, resolving LP #1783831.
80%
#2205 tests: add spread suite for meson plugin snapcraft merged Merged PR #2205 as commit 19c651af4, moving Meson plugin integration tests from Python into a Spread suite and resolving LP #1783837.
79%