← Back to issue list

docker: support for testing snapcraft in proposed

View original Github issue

Metadata

Project
snapcraft
Number
#2245
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2245 via commit 4a3095548, adding a xenial-proposed Docker image for testing the Snapcraft deb and removing an unnecessary multiverse edit.

Resolution: closed resolved

Reason: PR #2245 was merged as commit 4a3095548. The change added the proposed-snapcraft Docker test environment and was confirmed by the author's successful Snapcraft build test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Adding a dockerfile specifically tailored for testing the snapcraft deb in xenial-proposed. Also remove the multiverse sed from the standard Dockerfile as multiverse is already in the base image. LP: #1791116 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2245 via commit 4a3095548, adding a xenial-proposed Docker image for testing the Snapcraft deb and removing an unnecessary multiverse edit.
stealth/space-bunny-alpha — closed resolved Merged in #2245 (4a3095548), adding a Docker image for testing the xenial-proposed Snapcraft deb and removing an unnecessary multiverse sources edit.
qwen/qwen3.6-35b-a3b — — Merged additions for a xenial-proposed snapcraft test Dockerfile and cleanup of the standard Dockerfile. Changes received approval, passed CI checks, and were validated through successful container execution.
qwen3.6-35b-a3b-mtp-q6 — — Merged updates adding a Dockerfile for testing snapcraft in xenial-proposed and removing redundant multiverse sed from the standard Dockerfile. Confirmed successful snapcraft builds in the new container.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1791116 (confidence 100%)

    The PR implemented the requested Docker image for the linked Launchpad bug, which was subsequently closed.

Related issues

Issue Project State Summary Similarity
#1791116 docker file for xenial-proposed snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft#2245 (commit 4a3095548), adding a xenial-proposed Docker image for testing Snapcraft from the proposed pocket.
84%
#3210 docker: install snapd dependency snapcraft merged Merged PR #3210 in commit 42d3861a, adding snapd to Snapcraft Docker images so required snap pack operations continue working.
75%
#5057 docker: add workflow to test image works snapcraft closed Closed unmerged and superseded by merged PR #5063 (commit 24e70d6db), which removed the in-tree Dockerfile and directed users to canonical/snapcraft-rocks images.
72%
#2671 docker: remove snapcraft-wrapper snapcraft merged PR #2671 merged as commit 393956c09, deleting the now-obsolete docker/bin/snapcraft-wrapper left over after #2591 (b292b64d). Maintainers noted it broke the gnome-3-28-1804 image, to be fixed separately.
71%
#3144 docker: setup a multiarch build for snapcraft docker images snapcraft closed PR #3144 (multiarch snapcraft Docker images via QEMU) was closed unmerged by sergiusens in Dec 2020, since the base-image change (focal/core20) would break existing CI users; Docker images were being moved to a separate repo.
71%
#2883 docker: add core18 snap that snapcraft now uses as a base snapcraft merged Merged PR #2883 as commit 6bd9dac10, adding core18 to Docker images as Snapcraft's base and updating related comments.
70%