← Back to issue list

docker: add core18 snap that snapcraft now uses as a base

View original Github issue

Metadata

Project
snapcraft
Number
#2883
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged the addition of the core18 snap as snapcraft's Docker base, updating related comments for accuracy. Approved by one reviewer, the change was integrated after a minor authorship clarification.

Suggested action:

No scores available.

Issue body

Also update comments for correctness and syntax. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the addition of the core18 snap as snapcraft's Docker base, updating related comments for accuracy. Approved by one reviewer, the change was integrated after a minor authorship clarification.
qwen3.6-35b-a3b-mtp-q6 Merged updates adding core18 snap as the Docker base and correcting related comments. Changes were cherry-picked from #2851 and approved by maintainers.
qwen3.6-35b-a3b-mtp-q6 Merged. Integrates core18 snap as the Docker base and updates related comments. Changes were cherry-picked from PR #2851, with authorship attribution noted but accepted during review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4290 docker: add core22 base snapcraft closed Rejected and closed. Maintainers declined the core22 Docker base update due to legacy constraints, directing users to the new snapcraft-rocks initiative. The PR was superseded by canonical/snapcraft-rocks.
77%
#1846195 provide snapcraft docker image for core18 snapcraft (launchpad) open Request for canonical-provided core18-based snapcraft docker images (official ones were xenial-based). 7 years old, no comments or labels; core18 is EOL and the project has moved to core20+, so the request is no longer applicable.
77%
#3583 build providers: snapcraft's new base is core20 (CRAFT-544) snapcraft merged Merged into master. Replaced core18 injection with core20 as the new snapcraft base. Approved by one reviewer, passed CI, and achieved 100% diff coverage.
76%
#1826611 Running snapcraft 3 w/ core18 base in docker incorrectly reports missing lib deps snapcraft (launchpad) closed Closed as stale. Snapcraft resolved the issue by updating its Dockerfiles and migrating to OCI rocks for builds, eliminating the incorrect core18 dependency warnings in Docker.
76%
#2720 remote build: switch from core to core18 snapcraft merged Merged change switches remote build base from core to core18, aligning with snapcraft edge. Approved, passed CI, and modified one file.
74%
#3210 docker: install snapd dependency snapcraft merged Merged. Adds snapd installation to Docker images to satisfy snapcraft's new snap pack requirement. Approved by two reviewers, passed CI, and modified five files.
74%
#4118 init: use core22 base for `snapcraft init` snapcraft merged Merged. Updates snapcraft init to use core22 as the default base instead of core20. The command was relocated from snapcraft_legacy to snapcraft, and a spread test was added. Approved by reviewer and passed CI.
73%
#1576 docker: add the environment variable to setup core snapcraft merged Merged a one-line Dockerfile update adding the SNAPCRAFT_SETUP_CORE environment variable to enable straightforward snapcraft builds with classic confinement. The change was approved, passed CI checks, and successfully integrated.
73%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged updates the snap base to core20. Approved by two reviewers with passing CI checks. Changes affect 13 files, increase coverage by 0.07%, and update initialization templates to core20.
73%
#2712 snap: migrate to core18 snapcraft merged Merged the snap packaging migration to the core18 base. Approved by one reviewer, the update modified 8 files with 95 additions and 42 deletions, signed off by maintainer sergiusens.
73%