← Back to issue list

docker: remove snapcraft-wrapper

View original Github issue

Metadata

Project
snapcraft
Number
#2671
Type
pull request
State
merged
Author
abitrolly
Labels
—
Created
Updated
Closed

Current evaluation

PR #2671 merged as commit 393956c09, deleting the now-obsolete docker/bin/snapcraft-wrapper left over after #2591 (b292b64d). Maintainers noted it broke the gnome-3-28-1804 image, to be fixed separately.

Resolution: closed resolved

Reason: The pull request was approved and merged into master as commit 393956c09 ("docker: remove snapcraft-wrapper"), deleting the leftover script after #2591 made the Docker images self-contained. Follow-up breakage in the gnome-3-28-1804 image was acknowledged by kenvandine as an out-of-scope image fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Leftover after b292b64d74b643e2ddb3c1ac3f6d6a0bb9baffee. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2671 merged as commit 393956c09, deleting the now-obsolete docker/bin/snapcraft-wrapper left over after #2591 (b292b64d). Maintainers noted it broke the gnome-3-28-1804 image, to be fixed separately.
stealth/space-bunny-alpha — closed resolved Merged #2671 as commit 393956c09, deleting the obsolete snapcraft-wrapper left after #2591. A maintainer acknowledged the change broke the gnome-3-28-1804 image and planned to update it separately.
qwen/qwen3.6-35b-a3b — — Merged cleanup removing the leftover snapcraft-wrapper file. The change broke the gnome-3-28-1804 Docker image, which the maintainer acknowledged and committed to fixing separately. Missing code coverage upload did not block the merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the snapcraft-wrapper from the docker build. The change broke the gnome-3-28-1804 docker image, which maintainers acknowledged and planned to fix separately. Downstream breakage was noted but the change proceeded.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#2591 (confidence 92%)

    Commit b292b64d ('docker images: update to be self contained') superseded the wrapper, leaving it as dead code that #2671 removed.

  • Caused By: snapcore/snapcraft#2591 (confidence 70%)

    Downstream gnome-3-28-1804 Docker image broke after removal; kenvandine planned to update the image separately rather than restore the wrapper.

Related issues

Issue Project State Summary Similarity
#3210 docker: install snapd dependency snapcraft merged Merged PR #3210 in commit 42d3861a, adding snapd to Snapcraft Docker images so required snap pack operations continue working.
71%
#2245 docker: support for testing snapcraft in proposed snapcraft merged Merged in #2245 via commit 4a3095548, adding a xenial-proposed Docker image for testing the Snapcraft deb and removing an unnecessary multiverse edit.
71%
#2592 docker/bin/snapcraft-wrapper: use dpkg for architecture snapcraft closed PR #2592 was closed unmerged after its requested dpkg-based architecture change remained unfinished; the author questioned whether overriding SNAP_ARCH made it unnecessary.
71%