← Back to issue list

requirements.txt: stop using pymacaroons-pynacl

View original Github issue

Metadata

Project
snapcraft
Number
#2302
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #2302 merged (commit ff233cd72), dropping pymacaroons-pynacl from requirements.txt, resolving LP #1794703 runtime link failures; backported to legacy via #2303.

Resolution: closed resolved

Reason: The PR was merged into master as commit ff233cd72, removing the pymacaroons-pynacl requirement that clashed with pymacaroons and broke linking at runtime. The same change was later backported to the legacy branch through merged PR #2303.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1794703](https://bugs.launchpad.net/snapcraft/+bug/1794703) by no longer using pymacaroons-pynacl. It doesn't seem necessary, clashes with pymacaroons, and results in failures to link at runtime.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2302 merged (commit ff233cd72), dropping pymacaroons-pynacl from requirements.txt, resolving LP #1794703 runtime link failures; backported to legacy via #2303.
stealth/space-bunny-alpha — closed resolved Merged PR #2302 (commit ff233cd72) removed pymacaroons-pynacl from requirements.txt, fixing runtime link failures and dependency conflicts. Resolved LP #1794703.
stealth/space-bunny-alpha — closed resolved Merged #2302 (ff233cd72), removing pymacaroons-pynacl to resolve LP #1794703, dependency conflicts, and runtime linking failures.
qwen/qwen3.6-35b-a3b — — Merged. Removed pymacaroons-pynacl from requirements.txt to fix runtime linking failures and dependency conflicts. The package was unnecessary and clashed with pymacaroons, resolving bug LP: #1794703.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of pymacaroons-pynacl from requirements.txt, resolving LP: #1794703. The dependency was redundant, clashed with pymacaroons, and caused runtime linking failures. Applied to master.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2303 (confidence 92%)

    Backport of #2302 to the legacy branch, also merged, resolving LP: #1794703 there.

  • Related To: canonical/snapcraft#584 (confidence 55%)

    Earlier PR that introduced use of the pymacaroons package, the dependency pymacaroons-pynacl clashed with.

Related issues

Issue Project State Summary Similarity
#2303 [legacy] requirements.txt: stop using pymacaroons-pynacl snapcraft merged Merged into the legacy branch: backport of #2302 (commit ff233cd72) dropping pymacaroons-pynacl from requirements.txt, fixing LP: #1794703 (1 file, +1/-2).
93%
#5315 build(deps): move pymacaroon to a dev dependency snapcraft merged PR #5315 by mr-cal merged as commit f7ca63a10, moving pymacaroons from runtime dependencies to the dev dependency group; it is now only imported by tests/unit/conftest.py.
73%