build(deps): move pymacaroon to a dev dependency
Metadata
Current evaluation
PR #5315 by mr-cal merged as commit f7ca63a10, moving pymacaroons from runtime dependencies to the dev dependency group; it is now only imported by tests/unit/conftest.py.
Resolution: closed resolved
Reason: The PR was approved by 2 reviewers and merged to main as commit f7ca63a10; pyproject.toml now lists pymacaroons under [dependency-groups] dev and tests/unit/conftest.py is its only remaining consumer.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
The only non-test use of `pymacaroons` was in `_deserialize_macaroon()`, which has been unused since Snapcraft 7.0.6 thanks to #3794 ([here](https://github.com/canonical/snapcraft/pull/3794/files#diff-35204010f0b3823929448f4e8072b242c134b77932eae7d8cdc1efb2c0353404L83)).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #5315 by mr-cal merged as commit f7ca63a10, moving pymacaroons from runtime dependencies to the dev dependency group; it is now only imported by tests/unit/conftest.py. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5315 in f7ca63a10, moving pymacaroon to development dependencies after #3794 made its only non-test use obsolete in Snapcraft 7.0.6. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to move pymacaroon to dev dependencies. The package was only referenced in an unused deserialization function since v7.0.6. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged, moving pymacaroon to dev dependencies. The package was only referenced in a function unused since Snapcraft 7.0.6, removing an unnecessary production dependency. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#3794
(confidence 90%)
PR #3794 (commit 7194ef1) removed the last non-test use of _deserialize_macaroon(), making pymacaroon a test-only dependency.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #584 Use pymacaroons | snapcraft | merged | Merged canonical/snapcraft#584 in commit 28b94b375, replacing vendored pymacaroons with the packaged library; unit, integration, and snap tests passed. | |
| #2302 requirements.txt: stop using pymacaroons-pynacl | snapcraft | merged | PR #2302 merged (commit ff233cd72), dropping pymacaroons-pynacl from requirements.txt, resolving LP #1794703 runtime link failures; backported to legacy via #2303. | |
| #2303 [legacy] requirements.txt: stop using pymacaroons-pynacl | snapcraft | merged | Merged into the legacy branch: backport of #2302 (commit ff233cd72) dropping pymacaroons-pynacl from requirements.txt, fixing LP: #1794703 (1 file, +1/-2). |