← Back to issue list

waf plugin: support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2332
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2332 (commit bd896921b) adding base support to the Waf plugin, fixing Launchpad bug #1794803. Approved with 100% diff coverage; later generalised by #2499 (base: core) and get_build_base refactor.

Resolution: closed resolved

Reason: The pull request was merged into master via commit bd896921b, adding get_build_properties base handling to snapcraft/plugins/waf.py (+98/-17 across 6 files) to resolve LP bug #1794803. Follow-up commits e1cc2b91c (#2499) and e3b3b8870 extended the same base-support mechanism to all plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1794803 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2332 (commit bd896921b) adding base support to the Waf plugin, fixing Launchpad bug #1794803. Approved with 100% diff coverage; later generalised by #2499 (base: core) and get_build_base refactor.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2332 via commit bd896921b, adding base support to the Waf plugin and resolving LP #1794803.
stealth/space-bunny-alpha — closed resolved Merged #2332 via commit bd896921b, adding base support to the WAF plugin for Launchpad bug #1794803.
qwen/qwen3.6-35b-a3b — — Merged. Adds bases support to the WAF plugin, resolving Launchpad issue #1794803. Approved by a reviewer, passed CI checks, and modified 6 files (+98/-17 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation adding bases support to the waf plugin, resolving LP: #1794803. The change achieved 100% diff coverage and was integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapcraft#2499 (confidence 70%)

    Later commit e1cc2b91c generalises 'base: core' support in snapcraft.yaml, building on the Waf plugin base support introduced here.

  • Related To: snapcore/snapcraft#2984 (confidence 45%)

    Commit 38996d538 later moved snapcraft/plugins/waf.py into the new plugins package, carrying this change forward.

Related issues

Issue Project State Summary Similarity
#1794803 Update the waf plugin to be base aware snapcraft (launchpad) closed Updated the Waf plugin to be base-aware by merging snapcore/snapcraft PR #2332 in commit bd896921b.
74%
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
73%
#1611335 add plugin for the waf build environment snapcraft (launchpad) closed Waf build system support landed: PR canonical/snapcraft#716 by ~paelzer merged as commit 9cf5b2492, adding the waf plugin with bundled Waf plus unit/integration tests. Launchpad bug closed as fixed.
73%