meta: add assumes if using "full" app adapter
Metadata
Current evaluation
Merged as commit 2b5a254ef, adding assumes: [command-chain] when the full app adapter is used, resolving LP #1799295.
Resolution: closed resolved
Reason: PR #2379 was approved and merged as commit 2b5a254ef. It automatically adds the command-chain assumption required by the full app adapter.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently the snapcraft CLI supports a "full" app adapter that utilizes snapd's new `command-chain` functionality instead of app wrappers. However, `command-chain` still isn't contained within a stable snapd release. This PR resolves [LP: #1799295](https://bugs.launchpad.net/snapcraft/+bug/1799295) by, automatically adding an `assumes: [command-chain]` when using the "full" app adapter.
**Note:** This PR depends on https://github.com/snapcore/snapd/pull/6029, and assumes (heh) it will make it into v2.36. If it doesn't, we'll have to hard-code snapd versions instead, which isn't ideal since it's easy to lose track of what that means.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2b5a254ef, adding assumes: [command-chain] when the full app adapter is used, resolving LP #1799295. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2379 as commit 2b5a254ef: snapcraft now auto-adds `assumes: [command-chain]` to snap meta when the "full" app adapter is used, fixing LP #1799295. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2379 as commit 2b5a254ef, automatically adding assumes: [command-chain] for the full adapter and resolving LP #1799295. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. The change depends on snapd v2.36 and was merged with 100% test coverage. |
Update history
No update history recorded yet.
Related work
-
Blocked By:
snapd#6029
(confidence 99%)
The change depended on snapd command-chain support landing in a stable snapd release.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1799295 Snapcraft should add an "assumes" if full adapter is used | snapcraft (launchpad) | closed | Fixed by snapcraft PR #2379 ("meta: add assumes if using 'full' app adapter"), merged as commit 2b5a254ef; Snapcraft now adds assumes: [command-chain] when the full adapter is used. Maintainer ~kyrofa closed LP #1799295 citing that PR. | |
| #2343 schema, meta: add "full" app adapter | snapcraft | merged | Merged PR #2343 (commit d99c1fe43), adding the full app adapter via snapd command-chain instead of wrappers; legacy remained the default for compatibility. |