meta: add assumes if using "full" app adapter
Metadata
Current evaluation
Merged into master. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. Approved, passed CI, and achieved 100% diff coverage.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently the snapcraft CLI supports a "full" app adapter that utilizes snapd's new `command-chain` functionality instead of app wrappers. However, `command-chain` still isn't contained within a stable snapd release. This PR resolves [LP: #1799295](https://bugs.launchpad.net/snapcraft/+bug/1799295) by, automatically adding an `assumes: [command-chain]` when using the "full" app adapter.
**Note:** This PR depends on https://github.com/snapcore/snapd/pull/6029, and assumes (heh) it will make it into v2.36. If it doesn't, we'll have to hard-code snapd versions instead, which isn't ideal since it's easy to lose track of what that means.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. The change depends on snapd v2.36 and was merged with 100% test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Automatically injects assumes: [command-chain] into snap metadata when using the full app adapter, resolving LP: #1799295. Depends on snapd v2.36 and passed all tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2864 meta: assume command-chain fix for prepending snapcraft-runner | snapcraft | merged | Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks. | |
| #2343 schema, meta: add "full" app adapter | snapcraft | merged | Merged addition of a full app adapter to snapcraft. Replaces wrapper-based execution with snapd 2.36+ command-chain, resolving LP 1794532. The legacy adapter remains the default for compatibility. | |
| #2796 meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged fix for SNAPCRAFT-16C that converts the assumes configuration from a list to a set during initialization. This resolves a runtime exception when using command-chain by ensuring the add method functions correctly. Includes updated unit tests. |