← Back to issue list

gnome extension

View original Github issue

Metadata

Project
snapcraft
Number
#2398
Type
pull request
State
closed
Author
lucyllewy
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after review; the GNOME extension was reworked and merged in snapcore/snapcraft#2655 via commit b0c4319e5.

Resolution: closed superseded

Reason: PR #2655 was created to build on and replace #2398, then merged as commit b0c4319e5. The original proposal closed unmerged because its work was superseded.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? > I discussed this with @kyrofa directly at snapcraft summit. - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? > I have successfully run unit and spread tests relating to this feature. ----- Please review with prejudice :-)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after review; the GNOME extension was reworked and merged in snapcore/snapcraft#2655 via commit b0c4319e5.
stealth/space-bunny-alpha — closed superseded GNOME extension proposal was closed unmerged; PR #2655 replaced it and introduced the extension in commit b0c4319e5.
qwen/qwen3.6-35b-a3b — — Superseded by PR #2655, which rebased the GNOME extension implementation, resolved conflicts, fixed shellcheck violations, and integrated async execution support. The original PR was closed without direct merge.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #2655. The GNOME extension implementation was rebased, conflicts resolved, and shellcheck failures removed. Async execution support required substantial rewriting, completed in the successor pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2655 (confidence 99%)

    The replacement PR merged the GNOME extension implementation.

Related issues

Issue Project State Summary Similarity
#1805226 gnome extension snapcraft (launchpad) closed GNOME extension shipped in snapcraft 19.04: linked PR snapcore/snapcraft#2398 was closed unmerged and the reworked implementation merged in snapcraft#2655 (commit b0c4319e5, 'extensions: new gnome extension').
91%
#1853040 gnome-3-34 extension - build-environment needs to merge snapcraft (launchpad) closed Superseded by canonical/snapcraft#2956 (commit 1a411b0bb), which added GNOME 3.34 extension support; proposed fix snapcore/snapcraft#2794 was closed unmerged.
80%
#2655 Gnome extension snapcraft merged Merged PR #2655 introduced Snapcraft’s initial GNOME extension, including platform wiring and tests. The change landed as commit b0c4319e5.
79%
#1797627 Need glib extension snapcraft (launchpad) closed A standalone GLib extension was removed from the roadmap; snapcore/snapcraft#2359 closed unmerged, while the broader GNOME extension landed via #2655 (b0c4319e5).
79%
#2794 Add gnome 3 34 extension snapcraft closed Closed unmerged in favor of #2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb.
75%
#6278 feat(extensions): Add core26 support to the gnome extension snapcraft merged Merged PR #6278 as commit c05aed0c1, adding core26/GNOME 49 support and related tests to Snapcraft's GNOME extension.
72%
#3760 extensions: add core22 gnome snapcraft closed PR #3760 (core22 GNOME extension) was closed unmerged after review stalled with 14 unresolved comments. The same work landed via replacement PR #3798, merged as commit eddd1888c.
71%