gnome-3-34 extension - build-environment needs to merge
Metadata
Current evaluation
Superseded by canonical/snapcraft#2956 (commit 1a411b0bb), which added GNOME 3.34 extension support; proposed fix snapcore/snapcraft#2794 was closed unmerged.
Resolution: closed superseded
Reason: The proposed _utils.py merge fix in snapcore/snapcraft#2794 was closed unmerged. canonical/snapcraft#2956 landed commit 1a411b0bb and implemented GNOME 3.34 extension support through a different path.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The gnome-3-34 extension currently sets a given build-environment for all parts. However, if there is a user-defined build-environment in the yaml that uses the extension, the extension build-environment overwrites the user-defined one.
1. These two build-environments should be merged
2. Where a user has defined an environment variable that is also defined in the extension, the user-defined property should overwrite the extension one.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by canonical/snapcraft#2956 (commit 1a411b0bb), which added GNOME 3.34 extension support; proposed fix snapcore/snapcraft#2794 was closed unmerged. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by canonical/snapcraft#2956 (commit 1a411b0bb), which added GNOME 3.34 extension support; the proposed fix in #2794 was closed unmerged. | |
| stealth/space-bunny-alpha | — | closed stale | Closed without a recorded fix; the gnome-3-34 extension’s build-environment behavior remained unresolved, with no follow-up or linked implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned without resolution. The gnome-3-34 extension continues to overwrite user-defined build-environments instead of merging them with user values taking precedence. No comments or follow-up actions were recorded. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The requested build-environment merge and user-defined precedence logic for the gnome-3-34 extension was not implemented. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution or discussion. The feature request to merge build-environments, with user values taking precedence, was abandoned due to inactivity. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The gnome-3-34 extension continues to overwrite user-defined build-environments instead of merging them, leaving the requested precedence logic unimplemented. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. The gnome-3-34 extension still overwrites user-defined build-environments rather than merging them, leaving user variables unapplied. No fix or merge was implemented. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
snapcore/snapcraft#2794
(confidence 100%)
Proposed _utils.py changes for merging build environments; closed without merging.
-
Superseded By:
canonical/snapcraft#2956
(confidence 98%)
Commit 1a411b0bb implemented GNOME 3.34 extension support through a different path.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2398 gnome extension | snapcraft | closed | Closed unmerged after review; the GNOME extension was reworked and merged in snapcore/snapcraft#2655 via commit b0c4319e5. | |
| #1805226 gnome extension | snapcraft (launchpad) | closed | GNOME extension shipped in snapcraft 19.04: linked PR snapcore/snapcraft#2398 was closed unmerged and the reworked implementation merged in snapcraft#2655 (commit b0c4319e5, 'extensions: new gnome extension'). | |
| #2794 Add gnome 3 34 extension | snapcraft | closed | Closed unmerged in favor of #2956, which added the GNOME 3.34 extension and was merged as commit 1a411b0bb. | |
| #1883392 gnome-3-28-extension fails to build due to not including gcc | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#3178 (commit fb967fec7), adding gcc to the GNOME 3.28 extension so bindtextdomain.so could build. | |
| #2956 Add gnome 3 34 extension | snapcraft | merged | Merged as #2956 (commit 1a411b0bb), adding the gnome-3-34 extension for core18 and replacing #2794; later follow-ups added gcc build-packages (#2995) and XDG_DATA_DIRS/PYTHONPATH fixes (#3340, #3426). | |
| #1797627 Need glib extension | snapcraft (launchpad) | closed | A standalone GLib extension was removed from the roadmap; snapcore/snapcraft#2359 closed unmerged, while the broader GNOME extension landed via #2655 (b0c4319e5). |