← Back to issue list

Appstream desktop

View original Github issue

Metadata

Project
snapcraft
Number
#2435
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2435 added AppStream-derived desktop-file support to Snapcraft, updating 10 files with 95.91% diff coverage.

Resolution: closed resolved

Reason: PR #2435 was approved and merged into the project, completing the AppStream desktop-file support change. The only comment was a non-blocking Codecov report about a missing base upload.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2435 added AppStream-derived desktop-file support to Snapcraft, updating 10 files with 95.91% diff coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #2435 added AppStream-derived desktop-file support to Snapcraft, changing 10 files with 95.91% diff coverage.
stealth/space-bunny-alpha — closed resolved Merged #2435 added AppStream-derived desktop-file support to Snapcraft, changing 10 files with 95.91% diff coverage reported by Codecov.
stealth/space-bunny-alpha — closed resolved Merged snapcraft PR #2435, adding AppStream desktop support with one maintainer approval and no unresolved review comments.
stealth/space-bunny-alpha — closed resolved PR #2435 added AppStream desktop support and was merged after maintainer approval, changing 10 files and achieving 95.91% diff coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #2435 added AppStream desktop-file support to Snapcraft extractors.
qwen/qwen3.6-35b-a3b — — Merged pull request adding Appstream desktop support. Approved by one reviewer with no unresolved comments. CI passed, modifying 10 files with 95.91% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The Appstream desktop changes by sergiusens passed automated checks with 95.91% diff coverage and were successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1805431 adopt-info not finding desktop files snapcraft (launchpad) closed AppStream desktop-file lookup was fixed by merged PR snapcraft#2435 (commit 63a365159), correcting relative path resolution during extraction and metadata adoption.
76%
#2722 meta: fixes for desktop file handling snapcraft merged Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.
74%
#1828 Support desktop and icon in appstream handler snapcraft closed AppStream metadata gained icon and desktop support in merged PR canonical/snapcraft#1853 (commit ce3209468), closing the feature request.
71%
#1814898 appstream/desktop file icon extraction missing snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#2512 (commit 9e8601b80), adding desktop-file Icon= fallback and stock-icon lookup through the hicolor theme.
71%
#2952 spread: introduce appstream parse-info test snapcraft merged Merged in #2952 via 969af6c98, adding a spread test for AppStream adopt-info/parse-info data and ${SNAP} rewriting of desktop icon paths.
71%
#6298 fix: allow desktop files without an Exec key snapcraft merged Merged PR #6298 (commit ea842ae55) makes Snapcraft accept desktop entries lacking an Exec key, fixing #5799; Exec reformatting now only runs when the key exists and test_missing_exec_entry was updated.
71%