Currently the icon.{png,svg} is not being properly extracted via appstream/desktop file information. The current code expects the appstream data to contain something like `<icon type="local">assets/icon.png</icon>` which won't actually exist 99% of the time. The icon tags are almost exclusively injected by appstream-generator which is a distro-level tool that assembles "finalized" appstream. Part of this finalization is determining the actual icon files to use. For most applications the icon will be installed into an icon theme so the most suitable resolution is picked up. As such the current icon support is largely useless :| What needs to happen is the following: - existing code to look for icon tag - if no icon tag OR icon is not an absolute path OR absolute path doesn't exist in tree: - find desktop file (this may be set via <launchable> or inferred from <id> as is already the case in appstream.py) - get icon from desktop file - if icon is absolute path - use that - else - do an icon lookup [1] against the hicolor theme - (ideally one would actually be able to specify an additional "master" theme which is checked before hicolor; hicolor is the generic fallback but not necessarily the ideal visuals to use from a branding POV) NB: beware that theme icons may be png, xpm, svg, or svgz. Raising an error when an unsupported format is found is likely required (also unzipping svgz may be handy). Implementing this would also allow extending the current support so it not only supports `<icon type="local">` but also `<icon type="stock">` which is depending on the icon lookup. [1] https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html