sources: avoid marking changes to the snap directory as dirty
Metadata
Current evaluation
Merged a fix preventing local sources from being incorrectly marked as dirty when the snap directory changes. Resolves regression from PR #2419 and LP: #1816397.
Suggested action: —
No scores available.
Issue body
A regression was introduced with the fix in PR #2419 which fixed
LP: #1806746. Local sources were being marked as dirty when contents
of the snap directory changed.
LP: #1816397
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing local sources from being incorrectly marked as dirty when the snap directory changes. Resolves regression from PR #2419 and LP: #1816397. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve a regression where local sources were incorrectly marked as dirty upon snap directory changes. Fixes LP: #1816397. Code coverage shows 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression incorrectly marking local sources dirty when the snap directory changed. Resolves LP: #1816397, addressing a follow-up to PR #2419. Diff coverage achieved 100%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2167 many: detect local source changes | snapcraft | merged | Merged. Resolves LP: #1583718 by comparing local source timestamps to pull state. Snapcraft now automatically triggers re-pulling and subsequent steps on local changes, removing manual cleaning. Approved and merged after test fixes. | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files. |