← Back to issue list

Build-depend on git

View original Github issue

Metadata

Project
snapcraft
Number
#1137
Type
pull request
State
merged
Author
cjwatson
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#1137 (commit 8b3cb387d), adding git as a direct build dependency so Git source tests can invoke git.

Resolution: closed resolved

Reason: PR canonical/snapcraft#1137 was merged and implemented the requested build dependency in commit 8b3cb387d, resolving the missing-git test dependency.

Evaluated by: mr-cal-bot

No scores available.

Issue body

snapcraft.tests.sources.test_git expects to be able to call git, so snapcraft should build-depend on it directly. LP: [#1663605](https://bugs.launchpad.net/snapcraft/+bug/1663605)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1137 (commit 8b3cb387d), adding git as a direct build dependency so Git source tests can invoke git.
stealth/space-bunny-alpha — closed resolved Merged: snapcraft now directly build-depends on git so snapcraft.tests.sources.test_git can invoke it (LP bug #1663605).
qwen/qwen3.6-35b-a3b — — Merged pull request adding a build dependency on git to satisfy test execution requirements. Approved by one reviewer with a single line change to the build configuration.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds git as a direct build dependency for snapcraft to satisfy test requirements, resolving launchpad bug #1663605.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1663605 Local build fails due to missing build-dependency on git snapcraft (launchpad) closed Fixed by PR snapcore/snapcraft#1137 (commit 8b3cb387d), adding git as a Debian build dependency so Git source tests run in sbuild.
83%
#1720202 the snapcore/snapcraft image doesn't have git installed snapcraft (launchpad) closed Git was added to the Snapcraft build Dockerfile by merged PR snapcore/snapcraft#1575 (commit 8910ec250), enabling version: git.
74%
#5149 feat(snap): add git as craft.git to snapcraft snapcraft merged PR merged as commit c7d11ac65: adds a git binary as `craft.git` in $SNAP/libexec/snapcraft for Craft libraries needing a Git client (CRAFT-3547), with new spread tests.
73%
#1534411 Needs Test for Git sources snapcraft (launchpad) closed Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411.
72%
#1179 godeps plugin: add git to build-packages snapcraft merged Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
71%
#1802899 git package missing from build VM images snapcraft (launchpad) closed Snapcraft began automatically adding git to build-packages for version: git, fixing builds on VMs without git; merged in snapcore/snapcraft#2403 as a5719521c.
71%
#249 Git source: Support submodules. snapcraft merged Merged canonical/snapcraft#249 via 1984cb339, adding recursive Git cloning and submodule updates on pull to resolve LP #1536698.
70%
#4944 Install `git` inside core24 build environments snapcraft closed Git was bundled for core24 build environments by merged PR #5149 (commit c7d11ac65), making it available as craft.git on Snapcraft's build PATH.
70%