← Back to issue list

meta: fix management of snap/local

View original Github issue

Metadata

Project
snapcraft
Number
#2502
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2502 stopped snap/local from being copied into built snaps and improved copying for embedded directories in commit e48cd84d6.

Resolution: closed resolved

Reason: PR #2502 was merged and committed as e48cd84d6, fixing the handling of snap/local and embedded directories.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Do not copy snap/local into the snap, furthermore, improve the copy logic to work better with embedded directories. Fixes SNAPCRAFT-J2 Fixes SNAPCRAFT-JB Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2502 stopped snap/local from being copied into built snaps and improved copying for embedded directories in commit e48cd84d6.
stealth/space-bunny-alpha — closed resolved Merged PR #2502 via commit e48cd84d6, preventing snap/local from being packaged and improving copy handling for embedded directories.
stealth/space-bunny-alpha — closed resolved Merged PR #2502 prevents snap/local from being copied into built snaps and improves copy handling for embedded directories (commit e48cd84d6).
qwen/qwen3.6-35b-a3b — — Merged fix for snap/local management that prevents copying it into the snap and improves embedded directory copy logic. Approved, passed CI checks, and resolves SNAPCRAFT-J2 and SNAPCRAFT-JB.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing snap/local from being copied into the snap and improving copy logic for embedded directories. Resolves SNAPCRAFT-J2 and SNAPCRAFT-JB. Approved and merged by maintainer sergiusens.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2268 (confidence 88%)

    Earlier PR #2268 allowed snap/local through sanity checks; #2502 corrected its build-time handling.

Related issues

Issue Project State Summary Similarity
#1792203 Add support for snap/local directory snapcraft (launchpad) closed snap/local support was merged in canonical/snapcraft#2268 via commit 10bdb0473, allowing snap-specific local-source files and adding tests.
74%
#2268 sanity checks: allow snap/local dir snapcraft merged Merged PR #2268 via commit 10bdb0473 allowed snapcraft-specific files under snap/local/ and added tests, resolving LP #1792203.
73%
#2256 local source: don't include .snapcraft directory snapcraft merged Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks.
71%