snap packaging: fetch remote icons configured via appstream
Metadata
Current evaluation
Merged. Implements remote icon fetching for appstream-configured http(s) URLs, consolidates icon handling into _finalize_icon(), updates schema validation, and adds spread tests. Approved by reviewer and passed CI.
Suggested action: —
No scores available.
Issue body
- Consolidate various icon handling into _finalize_icon()
in _SnapPackaging.finalize_icon().
- Add support for http(s) URLs to 'icon' schema to allow for
validation for remote URLs once merged. To be clear, this
has the effect of allowing http(s) URLs in snapcraft.yaml.
Alternatively, we would either need to resolve it earlier
before the validation, or drop the schema validation check
on 'icon' after the appstream merge. The approach taken
here was to make behavior consistent.
- Add spread test for coverage.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Implements remote icon fetching for appstream-configured http(s) URLs, consolidates icon handling into _finalize_icon(), updates schema validation, and adds spread tests. Approved by reviewer and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds support for fetching remote http(s) icons configured via AppStream in snap packaging. Consolidates icon handling into _finalize_icon(), updates schema validation, and includes a spread test. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Introduces http(s) URL support for snap icon schemas to align with appstream configurations, consolidates icon handling into _finalize_icon(), and adds spread tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2512 many: better handling of appstream icons | snapcraft | merged | Merged changes improve AppStream icon handling by resolving stock icons at packaging time and falling back to desktop file definitions. Reviewers noted spec compliance concerns with theme parsing, but the PR was approved and merged. |