← Back to issue list

{catkin,colcon} plugin: remove old ROS key

View original Github issue

Metadata

Project
snapcraft
Number
#2586
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2586 (commit 830425bd9), removing the obsolete ROS key from the catkin and colcon plugins after Open Robotics' archive rebuild.

Resolution: closed resolved

Reason: The change was approved and merged into snapcraft as commit 830425bd9, completing removal of trust in the old ROS repository key.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Open Robotics' archive rebuild has completed and been rolled out. Time for the snapcraft CLI to stop trusting the old key. See https://discourse.ros.org/t/9454 for more information.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2586 (commit 830425bd9), removing the obsolete ROS key from the catkin and colcon plugins after Open Robotics' archive rebuild.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#2586 (commit 830425bd9), removing the obsolete ROS key from the catkin and colcon plugins after Open Robotics’ archive rebuild.
qwen/qwen3.6-35b-a3b — — Merged following maintainer approval and CI validation. The update removes the deprecated ROS signing key from the catkin and colcon plugins after Open Robotics completed their archive rebuild. Three files were modified, netting a 14-line reduction.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the obsolete Open Robotics signing key from the catkin and colcon plugins following their archive rebuild completion. Changes passed unit tests and received maintainer approval.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3664 ROS plugins v2: respect source-subdir key snapcraft merged Merged PR #3664, with commit 09eb744e5, made ROS v2 Colcon/catkin plugins respect source-subdir, removed a redundant dependency, and added subdirectory tests.
73%
#3268 v2 plugins: add catkin plugin snapcraft merged PR #3268 by kyrofa merged as commit d0f4177e9, adding the v2 Catkin plugin and refactoring shared ROS functionality out of the Colcon plugin; spread tests followed in #3282.
71%
#3113 colcon: use packages.ros.org/ros2 repository snapcraft merged Merged PR #3113 (commit d76f466f6) switched the colcon plugin from the broken repo.ros2.org apt source to packages.ros.org/ros2.
71%