← Back to issue list

{catkin,colcon} plugin: remove old ROS key

View original Github issue

Metadata

Project
snapcraft
Number
#2586
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged following maintainer approval and CI validation. The update removes the deprecated ROS signing key from the catkin and colcon plugins after Open Robotics completed their archive rebuild. Three files were modified, netting a 14-line reduction.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Open Robotics' archive rebuild has completed and been rolled out. Time for the snapcraft CLI to stop trusting the old key. See https://discourse.ros.org/t/9454 for more information.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following maintainer approval and CI validation. The update removes the deprecated ROS signing key from the catkin and colcon plugins after Open Robotics completed their archive rebuild. Three files were modified, netting a 14-line reduction.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the obsolete Open Robotics signing key from the catkin and colcon plugins following their archive rebuild completion. Changes passed unit tests and received maintainer approval.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the deprecated ROS signing key from catkin and colcon plugins after Open Robotics completed its archive rebuild. The change passed tests, achieved 100% diff coverage, received approval, and was integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3664 ROS plugins v2: respect source-subdir key snapcraft merged Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin v2 subdir handling. Approved by reviewers and passed CI.
74%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled.
71%
#3566 ROS 2 plugins v2 misc fixes snapcraft merged Merged after resolving conflicts and passing CI. Fixes ROS 2 plugins v2 by updating the colcon install path, resolving local packages during staging by removing the COLCON_IGNORE marker, and adding spread tests.
71%
#2456 plugins: add colcon plugin snapcraft merged Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files.
70%
#851 catkin plugin: nicely handle an invalid rosdistro. snapcraft merged Merged changes add rosdistro validation to the catkin plugin, replacing cryptic key errors with clear messages. Approved by reviewers and passed CI. Minor refactoring feedback was noted but did not block the merge.
70%